| Summary: | Elasticsearch - standalone colons should be escaped when performing a search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Searching - Elasticsearch | Assignee: | Ere Maijala <ere.maijala> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | ere.maijala, fridolin.somers, josef.moravec, lucas, marjorie.barry-vila, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 22228: Escape lone colons and make sure term is balanced
Bug 22228: Escape lone colons and make sure term is balanced Bug 22228: Escape lone colons and make sure term is balanced |
||
|
Description
Nick Clemens (kidclamp)
2019-01-29 16:30:23 UTC
Created attachment 84568 [details] [review] Bug 22228: Escape lone colons and make sure term is balanced Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes. Test plan: 1. Make sure the test case described in the bug works 2. Make sure tests pass: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Created attachment 85993 [details] [review] Bug 22228: Escape lone colons and make sure term is balanced Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes. Test plan: 1. Make sure the test case described in the bug works 2. Make sure tests pass: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Björn Nylén <bjorn.nylen(at)ub.lu.se> Created attachment 86010 [details] [review] Bug 22228: Escape lone colons and make sure term is balanced Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes. Test plan: 1. Make sure the test case described in the bug works 2. Make sure tests pass: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Björn Nylén <bjorn.nylen(at)ub.lu.se> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 not backporting this to the 18.05.x series |