Currently if you search with a colon it can cause failure or no results To recreate: Search for a term containing a colon i.e. Harry potter : the creature vault Note search fails Now try Harry potter \: the creature vault It works (maybe returns nothing)
Created attachment 84568 [details] [review] Bug 22228: Escape lone colons and make sure term is balanced Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes. Test plan: 1. Make sure the test case described in the bug works 2. Make sure tests pass: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
Created attachment 85993 [details] [review] Bug 22228: Escape lone colons and make sure term is balanced Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes. Test plan: 1. Make sure the test case described in the bug works 2. Make sure tests pass: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Björn Nylén <bjorn.nylen(at)ub.lu.se>
Created attachment 86010 [details] [review] Bug 22228: Escape lone colons and make sure term is balanced Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes. Test plan: 1. Make sure the test case described in the bug works 2. Make sure tests pass: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Björn Nylén <bjorn.nylen(at)ub.lu.se> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
not backporting this to the 18.05.x series