| Summary: | Data displayed in request list datatable is not sanitized | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
| Component: | ILL | Assignee: | Bugs List <koha-bugs> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
Wondering about this one - it currently blocks any progress on the ILL graph. Is it in the right spot of the graph? Should it be in Koha security? Hi Katrin - I've now moved it to the top of the dependency tree, I'm going to try and get a fix out in the next day or two. |
Request data displayed in the "Request view" or similar views is sanitized by the html filter in the template. However, the main request list table is generated via Datatables and is not sanitized. This can be demonstrated by entering a malicious string, such as: <script>alert('pwned');</script> Into the request notes field, then displaying the requests table. I've not yet investigated if column data that is generated via render functions is affected, or whether it's just the columns that are passed through by Datatables. Investigate how this has been addressed elsewhere in Koha. Also, possible mitigations can be seen here: https://datatables.net/manual/security