Bug 22389

Summary: Classification splitting sources regex - cannot consistentlyadd/delete
Product: Koha Reporter: Nick Clemens <nick>
Component: System AdministrationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15836    
Bug Blocks:    
Attachments: Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source
Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source

Description Nick Clemens 2019-02-21 15:23:41 UTC
On initial creation/save you do not have a delete button

if you save and reopen then you do have a delete, but if you delete all expression you cannot add a new one
Comment 1 Jonathan Druart 2019-02-21 16:45:27 UTC
Created attachment 85457 [details] [review]
Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source

The "Delete" link does not exist when the form is empty.

Test plan:
Create a new classification splitting source
Select "Regex" for routine
=> The delete link does not appear (you cannot remove if there is only
one input)
=> It a regex
=> The 2 delete links appear
Comment 2 Nick Clemens 2019-02-21 17:08:26 UTC
Created attachment 85467 [details] [review]
Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source

The "Delete" link does not exist when the form is empty.

Test plan:
Create a new classification splitting source
Select "Regex" for routine
=> The delete link does not appear (you cannot remove if there is only
one input)
=> It a regex
=> The 2 delete links appear

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 3 Nick Clemens 2019-02-22 15:26:50 UTC
Small fix, passing QA
Comment 4 Nick Clemens 2019-02-22 15:27:16 UTC
Awesome work all!

Pushed to master for 19.05
Comment 5 Martin Renvoize 2019-02-26 09:20:17 UTC
Pushed to 18.11.x for 18.11.04
Comment 6 Lucas Gass 2019-03-06 23:24:07 UTC
18.05.x is missing the 15836 dependency, won't backport