On initial creation/save you do not have a delete button if you save and reopen then you do have a delete, but if you delete all expression you cannot add a new one
Created attachment 85457 [details] [review] Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source The "Delete" link does not exist when the form is empty. Test plan: Create a new classification splitting source Select "Regex" for routine => The delete link does not appear (you cannot remove if there is only one input) => It a regex => The 2 delete links appear
Created attachment 85467 [details] [review] Bug 22389: (bug 15836 follow-up) Add Delete regex links on creating splitting source The "Delete" link does not exist when the form is empty. Test plan: Create a new classification splitting source Select "Regex" for routine => The delete link does not appear (you cannot remove if there is only one input) => It a regex => The 2 delete links appear Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Small fix, passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
18.05.x is missing the 15836 dependency, won't backport