| Summary: | Some labels in subscription add form has wrong parameter "for" | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
| Component: | Serials | Assignee: | Josef Moravec <josef.moravec> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, lucas, martin.renvoize, nick, sandboxes, severine.queune |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15149 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 22404: Fix parameter "for" of labels in subscription add form
Bug 22404: Fix parameter "for" of labels in subscription add form Bug 22404: Fix parameter "for" of labels in subscription add form |
||
|
Description
Josef Moravec
2019-02-25 08:39:59 UTC
Created attachment 85593 [details] [review] Bug 22404: Fix parameter "for" of labels in subscription add form Attribute "for" of tag labelshould contain input id, not name. Test plan: 1) Go to serials -> add subscription second step 2) Click on labels of these three fields: - First issue publication date - Subscription start date - Subscription end date --> without patch, nothing happen --> with path, the datepicker is shown Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 85721 [details] [review] Bug 22404: Fix parameter "for" of labels in subscription add form Attribute "for" of tag labelshould contain input id, not name. Test plan: 1) Go to serials -> add subscription second step 2) Click on labels of these three fields: - First issue publication date - Subscription start date - Subscription end date --> without patch, nothing happen --> with path, the datepicker is shown Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Useful one, thanks Josef ! Created attachment 85805 [details] [review] Bug 22404: Fix parameter "for" of labels in subscription add form Attribute "for" of tag labelshould contain input id, not name. Test plan: 1) Go to serials -> add subscription second step 2) Click on labels of these three fields: - First issue publication date - Subscription start date - Subscription end date --> without patch, nothing happen --> with path, the datepicker is shown Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 this is not broken in 18.05 but I assumed having the labels correct named could be helpful in the future. backported to 18.05.x for 18.05.11 |