To reproduce: add or edit a serial, Set dates for First issue, Subscripton start Subscription end do not set Subscription length. Test prediction pattern. You will get a list of 1000 issues, starting from first issue date (not subscription start date) and going well beyond subscripton end date. Expected: show only the issues within the date range. If subscription length is set to a number of issues, you only get these in the pattern. Also expected: start at subscription start date, not first issue date. I opened an extra bug for that, see Bug 15148 (Numbering pattern in my tests was set to 'Number')
What a dirty bug. I think I found a trivial fix. I'm on a patch.
Created attachment 85501 [details] [review] Bug 15149: Serial test prediction pattern does not consider end date To reproduce: 1) add a serial. 2) set first issue = today 3) set frequency = 1/month 4) dont set subscription length 5) set subscription start date = today 6) set subscription start date = today + 1 year 7) set numbering pattern = Number 8) test prediction pattern. => Without patch : you will get a list of 1000 issues, going well beyond subscripton end date. => With patch : shows only the issues within the date range.
Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 85523 [details] [review] Bug 15149: Serial test prediction pattern does not consider end date To reproduce: 1) add a serial. 2) set first issue = today 3) set frequency = 1/month 4) dont set subscription length 5) set subscription start date = today 6) set subscription start date = today + 1 year 7) set numbering pattern = Number 8) test prediction pattern. => Without patch : you will get a list of 1000 issues, going well beyond subscripton end date. => With patch : shows only the issues within the date range. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Looks good, thanks Frido !
Created attachment 85574 [details] [review] Bug 15149: Serial test prediction pattern does not consider end date To reproduce: 1) add a serial. 2) set first issue = today 3) set frequency = 1/month 4) dont set subscription length 5) set subscription start date = today 6) set subscription start date = today + 1 year 7) set numbering pattern = Number 8) test prediction pattern. => Without patch : you will get a list of 1000 issues, going well beyond subscripton end date. => With patch : shows only the issues within the date range. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: zhihui <zhihui@inlibro.com>
Created attachment 85586 [details] [review] Bug 15149: Serial test prediction pattern does not consider end date To reproduce: 1) add a serial. 2) set first issue = today 3) set frequency = 1/month 4) dont set subscription length 5) set subscription start date = today 6) set subscription start date = today + 1 year 7) set numbering pattern = Number 8) test prediction pattern. => Without patch : you will get a list of 1000 issues, going well beyond subscripton end date. => With patch : shows only the issues within the date range. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: zhihui <zhihui@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Passing QA as it fixes the described bug. Please notice there are some more bugs in the subsricption add form. But we can continue with them on another report, which I am going to open.
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
Pushed to 18.05.x for 18.05.11