| Summary: | Koha::EDI should not use Log::Log4perl directly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> | 
| Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> | 
| Status: | Pushed to stable --- | QA Contact: | Kyle M Hall (khall) <kyle> | 
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aude.charillon, david, victor | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | This enhancement changes the way EDI logging is done - it now uses the improved Koha::Logger, instead of Log::Log4perl. | |
| Version(s) released in: | 25.05.00,24.11.04 | Circulation function: | |
| Bug Depends on: | 14167 | ||
| Bug Blocks: | 38423 | ||
| Attachments: | Bug 22415: Update EDI to use Koha::Logger Bug 22415: Add new log config for EDI Bug 22415: Update EDI to use Koha::Logger Bug 22415: Add new log config for EDI Bug 22415: Update EDI to use Koha::Logger Bug 22415: Add new log config for EDI Bug 22415: (QA follow-up) Fix misc qa issues | ||
| 
        
          Description
        
        
          Martin Renvoize (ashimema)
        
        
        
        
          2019-02-26 14:04:49 UTC
        
       Still the case Still, still the case.... Created attachment 175402 [details] [review] Bug 22415: Update EDI to use Koha::Logger This patch updates the EDI code to use the Koha::Logger wrapper in preference to the bare Log::Log4perl module. Created attachment 175403 [details] [review] Bug 22415: Add new log config for EDI This patch adds the Log4perl configurations required to match the existing prior use of Log4perl in EDI code. Created attachment 175483 [details] [review] Bug 22415: Update EDI to use Koha::Logger This patch updates the EDI code to use the Koha::Logger wrapper in preference to the bare Log::Log4perl module. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Created attachment 175484 [details] [review] Bug 22415: Add new log config for EDI This patch adds the Log4perl configurations required to match the existing prior use of Log4perl in EDI code. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> It works! :) Without the patches from here, the tests of Bug 38423 fail. Because they use Koha::Logger to look what happened in the EDI process. This demonstrates that the patches here have the expected functionality. Created attachment 176341 [details] [review] Bug 22415: Update EDI to use Koha::Logger This patch updates the EDI code to use the Koha::Logger wrapper in preference to the bare Log::Log4perl module. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 176342 [details] [review] Bug 22415: Add new log config for EDI This patch adds the Log4perl configurations required to match the existing prior use of Log4perl in EDI code. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 176343 [details] [review] Bug 22415: (QA follow-up) Fix misc qa issues Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.04 |