Bug 22415

Summary: Koha::EDI should not use Log::Log4perl directly
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: Pushed to main --- QA Contact: Kyle M Hall (khall) <kyle>
Severity: enhancement    
Priority: P5 - low CC: aude.charillon, david, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
This enhancement changes the way EDI logging is done - it now uses the improved Koha::Logger, instead of Log::Log4perl.
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 14167    
Bug Blocks: 38423    
Attachments: Bug 22415: Update EDI to use Koha::Logger
Bug 22415: Add new log config for EDI
Bug 22415: Update EDI to use Koha::Logger
Bug 22415: Add new log config for EDI
Bug 22415: Update EDI to use Koha::Logger
Bug 22415: Add new log config for EDI
Bug 22415: (QA follow-up) Fix misc qa issues

Description Martin Renvoize (ashimema) 2019-02-26 14:04:49 UTC
We have Koha::Logger for instantiating Log4perl loggers now.. it should be used here too.
Comment 1 Martin Renvoize (ashimema) 2024-02-13 12:13:48 UTC
Still the case
Comment 2 Martin Renvoize (ashimema) 2024-12-12 12:45:02 UTC
Still, still the case....
Comment 3 Martin Renvoize (ashimema) 2024-12-12 13:28:22 UTC
Created attachment 175402 [details] [review]
Bug 22415: Update EDI to use Koha::Logger

This patch updates the EDI code to use the Koha::Logger wrapper in
preference to the bare Log::Log4perl module.
Comment 4 Martin Renvoize (ashimema) 2024-12-12 13:28:24 UTC
Created attachment 175403 [details] [review]
Bug 22415: Add new log config for EDI

This patch adds the Log4perl configurations required to match the
existing prior use of Log4perl in EDI code.
Comment 5 Victor Grousset/tuxayo 2024-12-16 01:58:21 UTC
Created attachment 175483 [details] [review]
Bug 22415: Update EDI to use Koha::Logger

This patch updates the EDI code to use the Koha::Logger wrapper in
preference to the bare Log::Log4perl module.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2024-12-16 01:58:23 UTC
Created attachment 175484 [details] [review]
Bug 22415: Add new log config for EDI

This patch adds the Log4perl configurations required to match the
existing prior use of Log4perl in EDI code.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 7 Victor Grousset/tuxayo 2024-12-16 01:59:06 UTC
It works! :)

Without the patches from here, the tests of Bug 38423 fail. Because they use Koha::Logger to look what happened in the EDI process. This demonstrates that the patches here have the expected functionality.
Comment 8 Kyle M Hall (khall) 2025-01-10 14:42:31 UTC
Created attachment 176341 [details] [review]
Bug 22415: Update EDI to use Koha::Logger

This patch updates the EDI code to use the Koha::Logger wrapper in
preference to the bare Log::Log4perl module.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall (khall) 2025-01-10 14:42:41 UTC
Created attachment 176342 [details] [review]
Bug 22415: Add new log config for EDI

This patch adds the Log4perl configurations required to match the
existing prior use of Log4perl in EDI code.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall (khall) 2025-01-10 14:42:43 UTC
Created attachment 176343 [details] [review]
Bug 22415: (QA follow-up) Fix misc qa issues

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Katrin Fischer 2025-01-10 18:20:38 UTC
Pushed for 25.05!

Well done everyone, thank you!