Bug 22415 - Koha::EDI should not use Log::Log4perl directly
Summary: Koha::EDI should not use Log::Log4perl directly
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on: 14167
Blocks: 38423
  Show dependency tree / graph
 
Reported: 2019-02-26 14:04 UTC by Martin Renvoize (ashimema)
Modified: 2025-01-10 18:20 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:

Attachments
Bug 22415: Update EDI to use Koha::Logger (4.29 KB, patch)
2024-12-12 13:28 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 22415: Add new log config for EDI (18.22 KB, patch)
2024-12-12 13:28 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 22415: Update EDI to use Koha::Logger (4.34 KB, patch)
2024-12-16 01:58 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Bug 22415: Add new log config for EDI (18.27 KB, patch)
2024-12-16 01:58 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Bug 22415: Update EDI to use Koha::Logger (4.40 KB, patch)
2025-01-10 14:42 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 22415: Add new log config for EDI (18.34 KB, patch)
2025-01-10 14:42 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 22415: (QA follow-up) Fix misc qa issues (4.25 KB, patch)
2025-01-10 14:42 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2019-02-26 14:04:49 UTC 
We have Koha::Logger for instantiating Log4perl loggers now.. it should be used here too.
Comment 1 Martin Renvoize (ashimema) 2024-02-13 12:13:48 UTC 
Still the case
Comment 2 Martin Renvoize (ashimema) 2024-12-12 12:45:02 UTC 
Still, still the case....
Comment 3 Martin Renvoize (ashimema) 2024-12-12 13:28:22 UTC 
Created attachment 175402 [details] [review]
Bug 22415: Update EDI to use Koha::Logger

This patch updates the EDI code to use the Koha::Logger wrapper in
preference to the bare Log::Log4perl module.
Comment 4 Martin Renvoize (ashimema) 2024-12-12 13:28:24 UTC 
Created attachment 175403 [details] [review]
Bug 22415: Add new log config for EDI

This patch adds the Log4perl configurations required to match the
existing prior use of Log4perl in EDI code.
Comment 5 Victor Grousset/tuxayo 2024-12-16 01:58:21 UTC 
Created attachment 175483 [details] [review]
Bug 22415: Update EDI to use Koha::Logger

This patch updates the EDI code to use the Koha::Logger wrapper in
preference to the bare Log::Log4perl module.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2024-12-16 01:58:23 UTC 
Created attachment 175484 [details] [review]
Bug 22415: Add new log config for EDI

This patch adds the Log4perl configurations required to match the
existing prior use of Log4perl in EDI code.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 7 Victor Grousset/tuxayo 2024-12-16 01:59:06 UTC 
It works! :)

Without the patches from here, the tests of Bug 38423 fail. Because they use Koha::Logger to look what happened in the EDI process. This demonstrates that the patches here have the expected functionality.
Comment 8 Kyle M Hall (khall) 2025-01-10 14:42:31 UTC 
Created attachment 176341 [details] [review]
Bug 22415: Update EDI to use Koha::Logger

This patch updates the EDI code to use the Koha::Logger wrapper in
preference to the bare Log::Log4perl module.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall (khall) 2025-01-10 14:42:41 UTC 
Created attachment 176342 [details] [review]
Bug 22415: Add new log config for EDI

This patch adds the Log4perl configurations required to match the
existing prior use of Log4perl in EDI code.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall (khall) 2025-01-10 14:42:43 UTC 
Created attachment 176343 [details] [review]
Bug 22415: (QA follow-up) Fix misc qa issues

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Katrin Fischer 2025-01-10 18:20:38 UTC 
Pushed for 25.05!

Well done everyone, thank you!