| Summary: | 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 22394 | ||
| Bug Blocks: | 14825 | ||
|
Description
Martin Renvoize (ashimema)
2019-03-14 08:55:18 UTC
* C4::Circulation::__FixOverduesOnReturn "FU/U" -> "FFOR/F" * C4::Circulation::_FixAccountForLostAndReturned "L/Rep/W" -> "LR" Those are all the cases I can find so far.. looks like at least the first case is already in discussion on other bugs. *** This bug has been marked as a duplicate of bug 22512 *** This is in effect a duplicate of bug 22512 at this point.. I believe once an accountype is 'set' during it's initial creation it should remain static and rather if it's "state" needs to be tracked we should use a specific field to track it as introduced in the above bug. *** This bug has been marked as a duplicate of bug 22512 *** _FixOverduesOnReturn now uses add_credit. _FixAccountForLostAndReturned does no longer exist. |