Currently the accountlines.accounttype field is used to denote both the 'type' of a credit or debit and often mixes in it's 'state'. This is bad design and leads to superflous 'types' in reality. Examples: * 'FU' (fine "updating") becomes 'F' (fine) once it's 'fixed'. * 'FU' (fine "updating") may become 'FFOR' (fine "forgiven"). * 'L' (lost item) may become 'LR' (lost returned). * 'Rep' (replaced?) may become 'LR' (lost returned). * 'W' (writeoff) may become 'LR' (lost returned). These type+state mixes can lead to confusion in both code and end user facing messages.
As bug 22511 also highlights.. this state mixing is also present for all the 'credit' types as they can go from any type to 'VOID'
Created attachment 86673 [details] [review] Bug 22512: Add status field to accountlines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
*** Bug 22510 has been marked as a duplicate of this bug. ***
Created attachment 86684 [details] [review] Bug 22512: Add status field to accountlines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86910 [details] [review] Bug 22512: Add status field to accountlines Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.