|
Description
Martin Renvoize (ashimema)
2019-03-15 12:40:23 UTC
Created attachment 86671 [details] [review] Bug 22518: Remove references to 'O' accounttype I went back over 12 years to and still only found "FIXME: What are these accounttypes" concerning the 'O' type and I couldn't find anywhere where it was being set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 86672 [details] [review] Bug 22518: Add database update 'just in case' All cases I could find where 'O' was referenced it was referenced alongside 'FU'.. as such I've written this DB update to case any last cases of 'O' and update them to 'FU' "just in case" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87019 [details] [review] Bug 22518: Remove references to 'O' accounttype I went back over 12 years to and still only found "FIXME: What are these accounttypes" concerning the 'O' type and I couldn't find anywhere where it was being set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87020 [details] [review] Bug 22518: Add database update 'just in case' All cases I could find where 'O' was referenced it was referenced alongside 'FU'.. as such I've written this DB update to case any last cases of 'O' and update them to 'FU' "just in case" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 87171 [details] [review] Bug 22518: Remove references to 'O' accounttype I went back over 12 years to and still only found "FIXME: What are these accounttypes" concerning the 'O' type and I couldn't find anywhere where it was being set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 87172 [details] [review] Bug 22518: Add database update 'just in case' All cases I could find where 'O' was referenced it was referenced alongside 'FU'.. as such I've written this DB update to case any last cases of 'O' and update them to 'FU' "just in case" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bonus points for adding the number of changed lines in the dbrev.. Created attachment 87174 [details] [review] Bug 22518: (QA follow-up) Add rows updated to feedback Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 87186 [details] [review] Bug 22518: (QA follow-up) Add rows updated to feedback Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |