| Summary: | Cannot create manual invoices | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> | 
| Component: | Fines and fees | Assignee: | Liz Rea <wizzyrea> | 
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> | 
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | m.de.rooy, tomascohen, wizzyrea | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | 14591 | ||
| Bug Blocks: | |||
| Attachments: | 
              Bug 22533: maninvoice.pl is using deprecated maininvoice() method
               Bug 22533: maninvoice.pl is using deprecated maininvoice() method Bug 22533: Fix manual invoices from patron accounting Bug 22533: Fix manual invoices from patron accounting  | 
      ||
| 
 
        
          Description
        
        
          Nick Clemens (kidclamp)
        
        
        
        
          2019-03-18 17:36:17 UTC
        
       
    Created attachment 86757 [details] [review] Bug 22533: maninvoice.pl is using deprecated maininvoice() method To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Created attachment 86838 [details] [review] Bug 22533: maninvoice.pl is using deprecated maininvoice() method To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> While this fixes a bug, we should move forward with bug 22393, which completely removes the use of manualinvoice. Sorry, I'd been meaning to get to this one. I think this is a reasonable temporary fix to get master happy again.. bug 22393 isn't ready for testing as is yet.. unfortunately it turned into a bit of a monster (see the dependency tree above it) which I'm working my way through presently. I actually think this bug is also somewhat mis-described, it's a circular dependency issue if I'm reading it right. Which I believe was introduced by the re-arrangement of use statements in the new overdues work bu (sorry, I missed it during QA :( ). In short.. I'd say go for this one whilst I continue to get the tree for 22393 into a good state for testing and qa. Created attachment 86851 [details] [review] Bug 22533: Fix manual invoices from patron accounting To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 86873 [details] [review] Bug 22533: Fix manual invoices from patron accounting To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Thanks Marcel, I just didn't get a chance to do the final qa on this yesterday with meetings.. nice to come to it this morning and see you've stepped into the breach.. Go Team! :) Awesome work all! Pushed to master for 19.05 Causation bug not in 18.11.x series.  |