Created attachment 86757 [details] [review] Bug 22533: maninvoice.pl is using deprecated maininvoice() method To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed.
Created attachment 86838 [details] [review] Bug 22533: maninvoice.pl is using deprecated maininvoice() method To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
While this fixes a bug, we should move forward with bug 22393, which completely removes the use of manualinvoice.
Sorry, I'd been meaning to get to this one. I think this is a reasonable temporary fix to get master happy again.. bug 22393 isn't ready for testing as is yet.. unfortunately it turned into a bit of a monster (see the dependency tree above it) which I'm working my way through presently. I actually think this bug is also somewhat mis-described, it's a circular dependency issue if I'm reading it right. Which I believe was introduced by the re-arrangement of use statements in the new overdues work bu (sorry, I missed it during QA :( ). In short.. I'd say go for this one whilst I continue to get the tree for 22393 into a good state for testing and qa.
Created attachment 86851 [details] [review] Bug 22533: Fix manual invoices from patron accounting To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 86873 [details] [review] Bug 22533: Fix manual invoices from patron accounting To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thanks Marcel, I just didn't get a chance to do the final qa on this yesterday with meetings.. nice to come to it this morning and see you've stepped into the breach.. Go Team! :)
Awesome work all! Pushed to master for 19.05
Causation bug not in 18.11.x series.