| Summary: | C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Johanna Räisä <johanna.raisa> |
| Component: | MARC Bibliographic record staging/import | Assignee: | Johanna Räisä <johanna.raisa> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | ere.maijala, johanna.raisa, joonas.kylmala, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23322 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Elastic fix for matching records | ||
|
Description
Johanna Räisä
2019-03-20 09:43:59 UTC
Created attachment 86778 [details] [review] Elastic fix for matching records Bug 22545: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES TEST PLAN: - Use Elastic as search engine - Turn off UseQueryParser systempreference - Turn on AggressiveMatchOnISBN systempreference - Stage records with ISBN rule - See that there are no matches - Apply the patch - Stage records again - See that matches are found How does the fix work? The patch commit doesn't explain it, could you add a short description there, too. (In reply to Joonas Kylmälä from comment #3) > How does the fix work? The patch commit doesn't explain it, could you add a > short description there, too. When using Elastic the get_matches uses the same search terms as query parser since the Elastic CCL support is lacking. What about fixing this part of Elasticsearch CCL support in Koha? (In reply to Joonas Kylmälä from comment #5) > What about fixing this part of Elasticsearch CCL support in Koha? Yes, that would be the ideal situation. Librarians have learned to search from Zebra with CCL. I went about this in a different way on Bug 23322, rather than enabling QueryParser solution I fixed the Non-QP solution Can you check if the patch there solves your issue and makes sense? It would be great to get an answer to the above Johanna, I'm very interested to know whether this bug is resolved for you with that alternative implementation or whether we still need to work here. (In reply to Nick Clemens from comment #7) > I went about this in a different way on Bug 23322, rather than enabling > QueryParser solution I fixed the Non-QP solution > > Can you check if the patch there solves your issue and makes sense? I tested this and it solves my bug, awesome! Your solution makes more sense than mine. :) |