Bug 22545 - C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES
Summary: C4::Matcher::get_matches aggressive isbn and issn search don't give any resul...
Status: RESOLVED DUPLICATE of bug 23322
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic record staging/import (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Johanna Räisä
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-20 09:43 UTC by Johanna Räisä
Modified: 2019-10-14 22:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Elastic fix for matching records (1.30 KB, patch)
2019-03-20 10:51 UTC, Johanna Räisä 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johanna Räisä 2019-03-20 09:43:59 UTC 
When using AggressiveMatchOnISBN or AggressiveMatchOnISSN preferences instead of UseQueryParser the search for duplicates fails. ES don't give any results, it seems that the problem is the query string.
Comment 1 Johanna Räisä 2019-03-20 10:51:59 UTC 
Created attachment 86778 [details] [review]
Elastic fix for matching records
Comment 2 Johanna Räisä 2019-03-21 11:34:51 UTC 
Bug 22545: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES

TEST PLAN:
- Use Elastic as search engine
- Turn off UseQueryParser systempreference
- Turn on AggressiveMatchOnISBN systempreference
- Stage records with ISBN rule
- See that there are no matches
- Apply the patch
- Stage records again
- See that matches are found
Comment 3 Joonas Kylmälä 2019-03-26 08:24:15 UTC 
How does the fix work? The patch commit doesn't explain it, could you add a short description there, too.
Comment 4 Johanna Räisä 2019-03-26 10:12:40 UTC 
(In reply to Joonas Kylmälä from comment #3)
> How does the fix work? The patch commit doesn't explain it, could you add a
> short description there, too.

When using Elastic the get_matches uses the same search terms as query parser since the Elastic CCL support is lacking.
Comment 5 Joonas Kylmälä 2019-03-26 12:17:03 UTC 
What about fixing this part of Elasticsearch CCL support in Koha?
Comment 6 Johanna Räisä 2019-04-05 05:20:07 UTC 
(In reply to Joonas Kylmälä from comment #5)
> What about fixing this part of Elasticsearch CCL support in Koha?

Yes, that would be the ideal situation. Librarians have learned to search from Zebra with CCL.
Comment 7 Nick Clemens (kidclamp) 2019-07-17 12:40:05 UTC 
I went about this in a different way on Bug 23322, rather than enabling QueryParser solution I fixed the Non-QP solution

Can you check if the patch there solves your issue and makes sense?
Comment 8 Martin Renvoize (ashimema) 2019-10-02 22:39:07 UTC 
It would be great to get an answer to the above Johanna, I'm very interested to know whether this bug is resolved for you with that alternative implementation or whether we still need to work here.
Comment 9 Johanna Räisä 2019-10-03 07:39:09 UTC 
(In reply to Nick Clemens from comment #7)
> I went about this in a different way on Bug 23322, rather than enabling
> QueryParser solution I fixed the Non-QP solution
> 
> Can you check if the patch there solves your issue and makes sense?

I tested this and it solves my bug, awesome! Your solution makes more sense than mine. :)
Comment 10 Katrin Fischer 2019-10-14 22:03:15 UTC 
Changing this to a duplicate of bug 23322 then.

*** This bug has been marked as a duplicate of bug 23322 ***