Summary: | Remove deprecated delete_expired_opac_registrations.pl cronjob | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Command-line Utilities | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | josef.moravec, magnus, nick, robin |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
The functionality of delete_expired_opac_registrations.pl was moved into the cleanup_database.pl cronjob. Please make sure to adjust your conjob configuration accordingly.
|
Version(s) released in: |
19.05.00
|
Circulation function: | |||
Bug Depends on: | 22465 | ||
Bug Blocks: | |||
Attachments: |
Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob
Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob Bug 22680: OPAC language footer not positioned correctly |
Description
Martin Renvoize (ashimema)
2019-03-26 09:36:25 UTC
*** Bug 22465 has been marked as a duplicate of this bug. *** Created attachment 87690 [details] [review] Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob Removes the deprecated script and changes the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference. To test: - Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl was deleted - Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is correct - Make sure there are no other reference to the removed script As we remove the other related script in this release, it would make sense to remove this one in 19.05 as well. Created attachment 87726 [details] [review] Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob Removes the deprecated script and changes the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference. To test: - Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl was deleted - Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay system preference is correct - Make sure there are no other reference to the removed script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> +1 Signing off Going to go straight for a PQA on this one.. no references found anywhere and it's a simple removal. Created attachment 87728 [details] [review] Bug 22680: OPAC language footer not positioned correctly This patch modifies the OPAC CSS so that the language-selection footer is positioned correctly. To test, apply the patch and rebuild the OPAC CSS. - Enable one or more translations in the OPAC - View a page in the OPAC which can display in your browser without a vertical scrollbar (for instance, the OPAC main page with no news items or OpacMainUserBlock). - The language-selection footer should appear at the bottom of the screen. At smaller browser heights the footer should scroll offscreen. - Test with content in the opaccredits system preference, and with OpacKohaUrl enabled. The footer should still be positioned correctly. Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series. |