Description
Katrin Fischer
2019-04-03 11:57:38 UTC
Created attachment 90101 [details] [review] Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title remains Fines and charges. Please let me know if you think the table title should change too. Sponsored-by: Catalyst IT. The patch apply correctly. However, I do believe it will better to use the same term in both place: the access tab and the page itself. Created attachment 90286 [details] [review] Bug 22627: (follow-up) Changed accountlines and sco to match OPAC Test plan: Same as previous patch Sponsored-by: Catalyst IT Created attachment 90287 [details] [review] Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. Created attachment 90288 [details] [review] Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. This looks nice. But when I try to sign-off I get: Found multiple bug references specified commits: https://bugs.koha-community.org/show_bug.cgi?id=22627 https://bugs.koha-community.org/show_bug.cgi?id=21578 (In reply to Lucas Gass from comment #6) > This looks nice. But when I try to sign-off I get: > > Found multiple bug references specified commits: > https://bugs.koha-community.org/show_bug.cgi?id=22627 > https://bugs.koha-community.org/show_bug.cgi?id=21578 Hi Lucas, works ok for me - maybe your branch was not clean? Created attachment 92141 [details] [review] Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92142 [details] [review] Bug 22627: Rename tab on my summary page This completes the first patch by also changing the tab on the OPAC summary page from "Fines" to "Charges". Created attachment 92577 [details] [review] Bug 22627: Renames OPAC fines tab to 'your charges' to be more inclusive Brought up on Bug 21578, the 'your fines' tab in the OPAC would be better named as 'your charges' as not all charges are fines, some are credits etc. To test: 1) In the OPAC, click on the user's name and note that the tab that was called your fines is now called your charges. 2) When you click on the tab, the title says Your charges, the breadcrumb says Your charges, and the table title is Your charges. Sponsored-by: Catalyst IT. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 92578 [details] [review] Bug 22627: Rename tab on my summary page This completes the first patch by also changing the tab on the OPAC summary page from "Fines" to "Charges". Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Enhancement not pushed to 19.05.x |