Bug 22628

Summary:	FFOR and VOID show up as codes to end users in OPAC, SCO and staff
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Fines and fees	Assignee:	Martin Renvoize <martin.renvoize>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	normal
Priority:	P5 - low	CC:	josef.moravec, martin.renvoize, nick
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	19.05
Circulation function:
Bug Depends on:	12166
Bug Blocks:	21953
Attachments:	Bug 22628: Add VOID and FFOR to relevant templates Bug 22628: Add VOID and FFOR to relevant templates Bug 22628: Add VOID and FFOR to relevant templates Bug 22628: Add VOID and FFOR to relevant templates

Description Katrin Fischer 2019-04-03 12:10:31 UTC

Looking at my database I can see FFOR and VOID as codes showing up in some places:

- SCO: VOID, FFOR
- Patron account in OPAC: VOID, FFOR
- Patron account in staff: FFOR, Voided

There might be others not translating right into the templates.

Choosing normal as this is an issue in the OPAC as well.

Comment 1 Martin Renvoize 2019-04-09 12:25:09 UTC

Created attachment 87604 [details] [review]
Bug 22628: Add VOID and FFOR to relevant templates

This patch adds the VOID and FFOR codes to the releveant templates for
display purposes

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 2 Liz Rea 2019-04-10 19:03:09 UTC

Created attachment 87731 [details] [review]
Bug 22628: Add VOID and FFOR to relevant templates

This patch adds the VOID and FFOR codes to the releveant templates for
display purposes

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Comment 3 Katrin Fischer 2019-04-10 20:11:39 UTC

Created attachment 87734 [details] [review]
Bug 22628: Add VOID and FFOR to relevant templates

This patch adds the VOID and FFOR codes to the releveant templates for
display purposes

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Nick Clemens (kidclamp) 2019-04-11 12:35:58 UTC

Rebase on top of 12166

Comment 5 Martin Renvoize 2019-04-11 18:11:30 UTC

Created attachment 87781 [details] [review]
Bug 22628: Add VOID and FFOR to relevant templates

This patch adds the VOID and FFOR codes to the releveant templates for
display purposes

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 6 Martin Renvoize 2019-04-11 18:11:57 UTC

Rebased as requested

Comment 7 Nick Clemens (kidclamp) 2019-04-12 11:48:37 UTC

Awesome work all!

Pushed to master for 19.05

Comment 8 Martin Renvoize 2019-04-25 13:06:59 UTC

Depends upon 12166 not in 18.11.x series.