Bug 22656

Summary: Report charts broken after bug 22023
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: TemplatesAssignee: Josef Moravec <josef.moravec>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: black23, martin.renvoize, nick, oleonard
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.05.00
Bug Depends on: 22023    
Bug Blocks:    
Attachments: Bug 22656: Fix charts in reports
Bug 22656: Fix charts in reports
Bug 22656: Fix charts in reports

Description Josef Moravec 2019-04-08 06:02:40 UTC

    
Comment 1 Josef Moravec 2019-04-08 06:07:12 UTC
Created attachment 87488 [details] [review]
Bug 22656: Fix charts in reports

This reverts a change on Create chart button in report toolbar made by
bug 22023

1) Confirm the bug
    a) Create some SQL report
    b) Run it and click on "Show chart settings" button
    c) There is no modal  or other way to actually draw the chart

2) Apply the patch
3) Go through 1) again - the modal and chart should work

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 2 Owen Leonard 2019-04-08 13:39:17 UTC
Created attachment 87522 [details] [review]
Bug 22656: Fix charts in reports

This reverts a change on Create chart button in report toolbar made by
bug 22023

1) Confirm the bug
    a) Create some SQL report
    b) Run it and click on "Show chart settings" button
    c) There is no modal  or other way to actually draw the chart

2) Apply the patch
3) Go through 1) again - the modal and chart should work

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2019-04-08 21:46:33 UTC
Created attachment 87559 [details] [review]
Bug 22656: Fix charts in reports

This reverts a change on Create chart button in report toolbar made by
bug 22023

1) Confirm the bug
    a) Create some SQL report
    b) Run it and click on "Show chart settings" button
    c) There is no modal  or other way to actually draw the chart

2) Apply the patch
3) Go through 1) again - the modal and chart should work

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Nick Clemens 2019-04-17 12:29:59 UTC
Awesome work all!

Pushed to master for 19.05
Comment 5 Martin Renvoize 2019-04-26 13:19:00 UTC
Bug with enhancement not in 18.11.x series.