|
Description
Katrin Fischer
2019-04-08 18:07:36 UTC
*** Bug 26437 has been marked as a duplicate of this bug. *** Created attachment 126593 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and open a News item 3. Notice a Save and continue button 4. Make some changes and use the Save and continue button, making sure it works. 5. Make sure it works using both the text (CodeMirror) editor and wysiwyg (TinyMCE) editor 6. Flip the 'AdditionalContentsEditor' system preference and repeat steps 4 & 5. 7. Turn on the NewsLog system preference 8. Make some changes and make sure those changes get logged when you use the Save and continue button Created attachment 126929 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and open a News item 3. Notice a Save and continue button 4. Make some changes and use the Save and continue button, making sure it works. 5. Make sure it works using both the text (CodeMirror) editor and wysiwyg (TinyMCE) editor 6. Flip the 'AdditionalContentsEditor' system preference and repeat steps 4 & 5. 7. Turn on the NewsLog system preference 8. Make some changes and make sure those changes get logged when you use the Save and continue button Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 127133 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and open a News item 3. Notice a Save and continue button 4. Make some changes and use the Save and continue button, making sure it works. 5. Make sure it works using both the text (CodeMirror) editor and wysiwyg (TinyMCE) editor 6. Flip the 'AdditionalContentsEditor' system preference and repeat steps 4 & 5. 7. Turn on the NewsLog system preference 8. Make some changes and make sure those changes get logged when you use the Save and continue button Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Really nice little addition to round up the work done in this area. I am sorry, just as I was done I thought about another thing to test: - Add a new additional contents entry - Try to save and continue without adding anything - mandatory fields complaint - Fill in code and other content - save and continue - no complaint, but the code will be empty again :( Another little bug: The save and continue changes your form from "additional contents" to "news" with the bug mentioned above. Created attachment 130155 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. Created attachment 130238 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Tested with the original and amended test plans. Works great, thanks for the patch - this is a superb idea! (In reply to Katrin Fischer from comment #7) > Another little bug: > The save and continue changes your form from "additional contents" to "news" > with the bug mentioned above. I am sorry, but I am still seeing this bug: 1) Add a new HTML customization 2) Leave title empty 3) Save and continue 4) Breadcrumbs and headings have changed to news This might relate to some other bugs we have in this area - adding Joubu. Created attachment 132365 [details] [review] Bug 22659: (follow-up) Add category to redirect If I follow Katrin's test plan : 1) Add a new HTML customization 2) Leave title empty 3) Save and continue --> no more redirection problems Katrin found, but the 'Content' field is reset This problem (or expected behaviour ?) exists for 'News' menu but only for the language specific tabs. For 'Default' tab, we have a warning pop-up asking to specify a title. I think it should be the same for 'HTML customization' menu. I also noticed that for HTML menu, it's possible to save a content only for a specific language without any content in 'Default' : is that expected ? > 1) Add a new HTML customization > 2) Leave title empty > 3) Save and continue > --> no more redirection problems Katrin found, but the 'Content' field is > reset > > This problem (or expected behaviour ?) exists for 'News' menu but only for > the language specific tabs. > For 'Default' tab, we have a warning pop-up asking to specify a title. > I think it should be the same for 'HTML customization' menu. > > I also noticed that for HTML menu, it's possible to save a content only for > a specific language without any content in 'Default' : is that expected ? Séverine, Thanks for testing. I believe you are now experiencing a bug that I filed: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30272 This happens with or without my patch for this bug. Created attachment 134802 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 134803 [details] [review] Big 22659: (follow-up) Add category to redirect Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 134804 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 134805 [details] [review] Big 22659: (follow-up) Add category to redirect Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> I think the sandbox had a few issues submitting that sign off; sorry for the noise. Apologies, Katrin - I initially missed that additional test you found. All tests working fine for me now with Lucas' follow up - but I do see the same issues Séverine has listed. It's hard to untangle what is this bug and what's normal behaviour - 29828 and 30272 are both having an impact, but as Lucas says, it seems they're both existing issues that this bug hasn't changed. Created attachment 135471 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 135472 [details] [review] Big 22659: (follow-up) Add category to redirect Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 135473 [details] [review] Bug 22659: (follow-up) Add category to redirect Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Please rebase ASAP. Thanks. Created attachment 136523 [details] [review] Bug 22659: Add save and continue button to additional-contents.tt To test: 1. Apply patch and restart everything 2. Go to Tools > News and create some new additional content. 3. Notice a Save and continue button 4. Try saving and contining. 5. Make sure if you are using the CodeMirror editor that you are still in the CodeMirror editor 6. Try 2 - 5 again but with the wysiwyg editor, make sure when you save and continue you remain in the wysiwyg editor. 7. If you are saving and contining from News make sure you remain in News, when you are saving and contining from HTML customizations make sure you remain there. 8. Turn on the NewsLog system preference 9. With the NewsLog on make sure your content is being logged correctly when you sabe and continue. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 136524 [details] [review] Bug 22659: (follow-up) Add category to redirect Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> rebased for current master and reset to NSO This was actually PQA :-D Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.04 backported to 21.11.x for 21.11.11 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. |