Bug 22666

Summary: When using authority records in a bibliographic record, the order of the subfields is not sent over
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: MARC Authority data supportAssignee: Marion Durand <marion.durand>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: andrew, fridolin.somers, josef.moravec, marion.durand, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25387
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
When creating an authority record there is the possibility to reorder the subfields. However this order was not sent back to the bibliographic records when creating a link to the authority.
Version(s) released in:
22.11.00
Circulation function:
Attachments: Bug 25387: The order of authority subfield is not sent over to bibliographic record
Bug 25387: The order of authority subfield is not sent over to bibliographic record
Bug 25387: The order of authority subfield is not sent over to bibliographic record

Description Caroline Cyr La Rose 2019-04-08 19:08:06 UTC
It is possible to reorder subfields in the authority frameworks, but then, when the authority records are used in bibliographic records, the order is not transferred.

How to reproduce (for MARC21):

1.  Create a 'Topic term' authority
1.1 Go in Authorities
1.2 Click on 'New authority'
1.3 Choose 'Topic term,
1.4 Fill in the mandatory fields (normally 000, 003, 005, 008 and 040$c)
1.5 Click on the tab 1
1.6 Open field 150
1.7 Write in the following information
    - a: Villages
    - x: Fiction
    - z: Québec (Province)
1.8 Use the arrows to move the z subfield up above the x subfield (desired order: a, z, x)
1.9 Save the record

2.  Use the authority in a bibliographic record
2.1 Go in Cataloguing
2.2 Click on 'New record'
2.3 Choose 'Default framework'
2.4 Fill in the mandatory fields (normally 000, 003, 005, 008, 040$c, 245$c and 942$c)
2.5 Click on the tab 6
2.6 Click on the 'tag editor' button next to the 650$a subfield
2.7 Search for 'Villages'
2.8 Choose the 'Villages Québec (Province) Fiction' authority
EXPECTED RESULT: The subfields should be inserted in the same order as they are in the authority record (a, z, x)
Comment 1 Marion Durand 2022-01-17 14:37:09 UTC
Created attachment 129535 [details] [review]
Bug 25387: The order of authority subfield is not sent over to bibliographic record

When creating an authority record there is the possibility to reorder
the subfield. However this order is not sent back to the bibliographic
records when using this authority in a bibliographic record.

This patch make the order of subfield be sent back to bibliographic
record when the autority is used.
Field that are fill are sent to the begining of the bibliographic record
in the same order as in the authority record.

Test plan:
1- Find or create an authority record and reorder some subfield
2- Use this authority in a bibliographic record
3- Observe that the order of the subfield is not transferred from the
   authority record to the bibliographic record
4- Apply the patch
5- Repeat step 1 and 2 again
6- Observe that the order of the subfield is now transferred from the
   authority record to the bibliographic record
Comment 2 George Veranis 2022-09-01 19:30:52 UTC
Created attachment 140060 [details] [review]
Bug 25387: The order of authority subfield is not sent over to bibliographic record

When creating an authority record there is the possibility to reorder
the subfield. However this order is not sent back to the bibliographic
records when using this authority in a bibliographic record.

This patch make the order of subfield be sent back to bibliographic
record when the autority is used.
Field that are fill are sent to the begining of the bibliographic record
in the same order as in the authority record.

Test plan:
1- Find or create an authority record and reorder some subfield
2- Use this authority in a bibliographic record
3- Observe that the order of the subfield is not transferred from the
   authority record to the bibliographic record
4- Apply the patch
5- Repeat step 1 and 2 again
6- Observe that the order of the subfield is now transferred from the
   authority record to the bibliographic record
Comment 3 Katrin Fischer 2022-10-18 20:10:49 UTC
Created attachment 142093 [details] [review]
Bug 25387: The order of authority subfield is not sent over to bibliographic record

When creating an authority record there is the possibility to reorder
the subfield. However this order is not sent back to the bibliographic
records when using this authority in a bibliographic record.

This patch make the order of subfield be sent back to bibliographic
record when the autority is used.
Field that are fill are sent to the begining of the bibliographic record
in the same order as in the authority record.

Test plan:
1- Find or create an authority record and reorder some subfield
2- Use this authority in a bibliographic record
3- Observe that the order of the subfield is not transferred from the
   authority record to the bibliographic record
4- Apply the patch
5- Repeat step 1 and 2 again
6- Observe that the order of the subfield is now transferred from the
   authority record to the bibliographic record

https://bugs.koha-community.org/show_bug.cgi?id=22666

Signed-off-by: George Veranis <gveranis@dataly.gr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-10-18 20:11:13 UTC
George, I have added your sign-off line to the patch, assuming you meant to sign off.
Comment 5 Tomás Cohen Arazi (tcohen) 2022-10-25 14:39:10 UTC
Patches pushed to master for 22.11. Thanks!
Comment 6 Katrin Fischer 2022-12-04 12:30:15 UTC
*** Bug 24179 has been marked as a duplicate of this bug. ***
Comment 7 Katrin Fischer 2022-12-04 12:32:29 UTC
Has this been considered for backporting yet? I think it might be more of a bug than an enh. It also was reported as an issue with older versions on bug 24179.
Comment 8 Fridolin Somers 2024-05-29 07:35:46 UTC
Arg wrong number in commit message: Bug 25387 instead of Bug 22666
Wrong in release note.
Too late ;)