| Summary: | Koha::Acquisition::Bookseller methods should return Koha::Objects using the DBIx::Class relationships | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 22407 | ||
| Attachments: |
Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods
Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods |
||
|
Description
Martin Renvoize (ashimema)
2019-04-11 09:05:17 UTC
Created attachment 98157 [details] [review] Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods To match PERL15 we change the behavior of Koha::Object methods to make them use the DBIx::Class relationships. Test plan: - Create a vendor, basket and contact - Edit the vendor => the contact must appears - Go to the view of a vendor => you cannot delete the vendor, it has a basket attached - Create another vendor, without basket - Go to the view of the vendor => You can delete it Additionally: % prove t/db_dependent/Koha/Acquisition/Booksellers.t must return green *** Bug 22686 has been marked as a duplicate of this bug. *** Created attachment 98510 [details] [review] Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods To match PERL15 we change the behavior of Koha::Object methods to make them use the DBIx::Class relationships. Test plan: - Create a vendor, basket and contact - Edit the vendor => the contact must appears - Go to the view of a vendor => you cannot delete the vendor, it has a basket attached - Create another vendor, without basket - Go to the view of the vendor => You can delete it Additionally: % prove t/db_dependent/Koha/Acquisition/Booksellers.t must return green Signed-off-by: David Nind <david@davidnind.com> Created attachment 101868 [details] [review] Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods To match PERL15 we change the behavior of Koha::Object methods to make them use the DBIx::Class relationships. Test plan: - Create a vendor, basket and contact - Edit the vendor => the contact must appears - Go to the view of a vendor => you cannot delete the vendor, it has a basket attached - Create another vendor, without basket - Go to the view of the vendor => You can delete it Additionally: % prove t/db_dependent/Koha/Acquisition/Booksellers.t must return green Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, passes QA script and is an obvious improvement.. Passing QA Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |