|
Description
Tomás Cohen Arazi (tcohen)
2019-04-12 13:48:43 UTC
Created attachment 87932 [details] [review] Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl This patch removes many DB queries and uses state-of-the-art Koha code to accomplish the same things it did before. To test: - Apply this patch - Open opac-ISBDdetail.pl for a known record => SUCCESS: No behaviour change. - Sign off :-D Created attachment 87938 [details] [review] Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl This patch removes many DB queries and uses state-of-the-art Koha code to accomplish the same things it did before. To test: - Apply this patch - Open opac-ISBDdetail.pl for a known record => SUCCESS: No behaviour change. - Sign off :-D Signed-off-by: Bin Wen <bin.wen@inlibro.com> Created attachment 88356 [details] [review] Bug 22696: (follow-up) Use new relationship for prefetching Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 88376 [details] [review] Bug 22696: Prefetch items too Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 88515 [details] [review] Bug 22696: Simplify visibility logic in opac-ISBDdetail.pl This patch removes many DB queries and uses state-of-the-art Koha code to accomplish the same things it did before. To test: - Apply this patch - Open opac-ISBDdetail.pl for a known record => SUCCESS: No behaviour change. - Sign off :-D Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 88516 [details] [review] Bug 22696: (follow-up) Use new relationship for prefetching Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 88517 [details] [review] Bug 22696: Prefetch items too Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice simplification of the logic, no regressions found. Passing QA Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series. |