In order to better organize the code for checking visibility confingurations in many opac-*.pl controller scripts this method will be introduced. At the end of the path, it will be replaced by a table column on bug 22457.
Created attachment 87908 [details] [review] Bug 22694: Unit tests
Created attachment 87909 [details] [review] Bug 22694: Add Koha::Patron::Category->override_hidden_items This patch introduces a method to determine for a given category if patrons belonging to it override OpacHiddenItems policies. To test: - Apply the patches - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D
Created attachment 88509 [details] [review] Bug 22694: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 88510 [details] [review] Bug 22694: Add Koha::Patron::Category->override_hidden_items This patch introduces a method to determine for a given category if patrons belonging to it override OpacHiddenItems policies. To test: - Apply the patches - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple to test, works as expected and makes sense. Signing Off
Created attachment 88513 [details] [review] Bug 22694: Unit tests Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 88514 [details] [review] Bug 22694: Add Koha::Patron::Category->override_hidden_items This patch introduces a method to determine for a given category if patrons belonging to it override OpacHiddenItems policies. To test: - Apply the patches - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Switching my SO to a PQA and grabbing an SO from Bin Wen as he must have tested this as part of SO on bug 22696.
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.