Summary: | RenewLoan return wrong datetime format | ||
---|---|---|---|
Product: | Koha | Reporter: | Arthur Suzuki <arthur.suzuki> |
Component: | Web services | Assignee: | Arthur Suzuki <arthur.suzuki> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 22891 | ||
Bug Blocks: | |||
Attachments: |
Bug 22742: FIX : RenewLoan returns correct datetime format
Bug 22742: FIX : RenewLoan returns correct datetime format Bug 22742: FIX : RenewLoan returns correct datetime format Bug 22742: FIX : RenewLoan returns correct datetime format Bug 22742: ILS-DI - Fix datetime format returned by RenewLoan |
Description
Arthur Suzuki
2019-04-19 09:47:58 UTC
Created attachment 88341 [details] [review] Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Created attachment 89565 [details] [review] Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Created attachment 89568 [details] [review] Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Bin Wen <bin.wen@inlibro.com> Created attachment 89569 [details] [review] Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Hi Arthur, please check our guidelines for commit messages :) https://wiki.koha-community.org/wiki/Commit_messages Now: [PATCH] Bug 22742: FIX : RenewLoan returns correct datetime format Better: Bug 22742: ILS-DI: Fix datetime format returned by RenewLoan I am sorry, but I am not able to test this further. RenewLoan dies for me: circular data structures not supported at /home/vagrant/kohaclone/opac/ilsdi.pl line 233. or: Can't encode a value of type: CODE at /home/vagrant/kohaclone/opac/ilsdi.pl line 233. URL I used: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 I am marking this as BLOCKED and dependent on the new bug 22891 I filed. While I can see that this change should work, usually a unit test would be needed for any change in a .pm file. Created attachment 89654 [details] [review] Bug 22742: ILS-DI - Fix datetime format returned by RenewLoan Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Bug caused by enhancement not in 18.11.x series. |