I am getting an error message when trying to test RenewLoan from ILS-DI: circular data structures not supported at /home/vagrant/kohaclone/opac/ilsdi.pl line 233. or: Can't encode a value of type: CODE at /home/vagrant/kohaclone/opac/ilsdi.pl line 233. URL I used: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 Itemnumber = 756 is checked out to my patron with the borrowernumber 51
Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem
Created attachment 89640 [details] [review] Bug 22891: Add tests
Created attachment 89641 [details] [review] Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI) From commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem A missing 'unless' test made RenewHold return prematurely: return $issue; should have been return unless $issue; Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 With different situations: 1. Item is checked out to the patron 2. Item is not checked out to the patron 3. Item does not exist 4. Patron does not exist
Created attachment 89650 [details] [review] Bug 22891: Add tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 89651 [details] [review] Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI) From commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem A missing 'unless' test made RenewHold return prematurely: return $issue; should have been return unless $issue; Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 With different situations: 1. Item is checked out to the patron 2. Item is not checked out to the patron 3. Item does not exist 4. Patron does not exist Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Combining SO and QA
Awesome work all! Pushed to master for 19.05
Bug caused by enhancement not in 18.11.x series.