|
Description
Jonathan Druart
2019-04-24 04:00:16 UTC
Created attachment 88587 [details] [review] Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item (You may need the patches on bug 22669) - Change the collection code value => The "Collection code" column must be filled with the new value Created attachment 88588 [details] [review] [<=18.11.x version] Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item - Change the collection code value => The "Collection code" column must be filled with the new value Hiya, sorry I got following conflict when applying this Auto-merging catalogue/getitem-ajax.pl CONFLICT (content): Merge conflict in catalogue/getitem-ajax.pl Failed to merge in the changes. Patch failed at 0001 Bug 22762: Fix items.collection display on receiving (In reply to Claire Gravely from comment #3) > Hiya, sorry I got following conflict when applying this > > Auto-merging catalogue/getitem-ajax.pl > CONFLICT (content): Merge conflict in catalogue/getitem-ajax.pl > Failed to merge in the changes. > Patch failed at 0001 Bug 22762: Fix items.collection display on receiving sorry, just saw the second patch is for other versions. First applies just fine! Created attachment 88747 [details] [review] Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item (You may need the patches on bug 22669) - Change the collection code value => The "Collection code" column must be filled with the new value Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> note: I have NOT tested the second patch for earlier versions. Created attachment 88757 [details] [review] Bug 22762: Fix items.collection display on receiving Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem The log says: The method Koha::Item->collection is not covered by tests! It has highlighted an older problem: Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). Test plan: - Set acqcreateitem to "when placing an order" - Receive an order with items => The "Collection code" column must be filled with the items.ccode value - Edit an item (You may need the patches on bug 22669) - Change the collection code value => The "Collection code" column must be filled with the new value Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Awesome work all! Pushed to master for 19.05 18.11 version pushed to 18.11.x for 18.11.05. Thanks Jonathan. backported to 18.05.x for 18.05.13 Any idea how "catalogue/getitem-ajax.pl" gets used here? I don't see it referenced anywhere in Koha? |