| Summary: | C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | SIP2 | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | andrew, colin.campbell, fridolin.somers, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.05,22.11.11
|
|
| Circulation function: | |||
| Bug Depends on: | 16899 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 22873: Add comment to explain what disallow_overpayment is for
Bug 22873: Add comment to explain what disallow_overpayment is for |
||
|
Description
Martin Renvoize (ashimema)
2019-05-09 10:05:13 UTC
I am not sure that this does nothing, there is some code in FeePayment.pm that checks for it:
if ($disallow_overpayment) {
return 0 if $account->balance < $amt;
}
I'm looking at a couple patrons on a 19.11 install where payments were double-submitted. The first payment set the amountoutstanding on the fine to 0. The second payment posted to their account and tied to the fine via account_offsets, but with $0 applied. So the payment wasn't refused, but Koha knew enough not to make the fine have a negative amount due. It is used in a SIP option. Take a look at etc/SIPconfig.xml in master. (In reply to Kyle M Hall from comment #3) > It is used in a SIP option. Take a look at etc/SIPconfig.xml in master. So should this be closed? (In reply to Katrin Fischer from comment #4) > (In reply to Kyle M Hall from comment #3) > > It is used in a SIP option. Take a look at etc/SIPconfig.xml in master. > > So should this be closed? Let's add a comment so future devs will know what it is there. Created attachment 156168 [details] [review] Bug 22873: Add comment to explain what disallow_overpayment is for Created attachment 156169 [details] [review] Bug 22873: Add comment to explain what disallow_overpayment is for Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.05 Nice work everyone! Pushed to oldstable for 22.11.x |