Bug 22873 - C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
Summary: C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 16899
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-09 10:05 UTC by Martin Renvoize
Modified: 2020-07-09 13:35 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2019-05-09 10:05:13 UTC
The `disallow_overpayment` parameter that's expected to be passed to the pay method of FeePayment does nothing.. it should either be removed or implimented.
Comment 1 Katrin Fischer 2019-05-11 23:23:51 UTC
I am not sure that this does nothing, there is some code in FeePayment.pm that checks for it:

if ($disallow_overpayment) {
    return 0 if $account->balance < $amt;
}
Comment 2 Andrew Fuerste-Henry 2020-07-08 19:28:01 UTC
I'm looking at a couple patrons on a 19.11 install where payments were double-submitted. The first payment set the amountoutstanding on the fine to 0. The second payment posted to their account and tied to the fine via account_offsets, but with $0 applied. So the payment wasn't refused, but Koha knew enough not to make the fine have a negative amount due.
Comment 3 Kyle M Hall 2020-07-09 13:35:02 UTC
It is used in a SIP option. Take a look at etc/SIPconfig.xml in master.