| Summary: | Trying to clear search history via the navbar X doesn't clear any searches | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Margaret Hade <margaret> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart, lucas, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.05.00, 18.11.06
|
|
| Circulation function: | |||
| Bug Depends on: | 21479 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches
Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches |
||
|
Description
Margaret Hade
2019-05-09 21:49:35 UTC
Created attachment 89548 [details] [review] Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches This patch undoes a mistake introduced in my patch for Bug 21479. A "preventDefault()" was added to the search history clear button by mistake. The "confirmDelete" function only works if the default action of the link is allowed to complete. To test you must have the EnableOpacSearchHistory system preference enabled. Apply the patch and log into the OPAC as a patron who has a search history. Click the "X" link in the header next to the "Search history" link. Confirm that you want to clear your search history. The page should refresh. Navigate to your account -> Your search history to confirm that your search history has been cleared. Created attachment 89549 [details] [review] Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches This patch undoes a mistake introduced in my patch for Bug 21479. A "preventDefault()" was added to the search history clear button by mistake. The "confirmDelete" function only works if the default action of the link is allowed to complete. To test you must have the EnableOpacSearchHistory system preference enabled. Apply the patch and log into the OPAC as a patron who has a search history. Click the "X" link in the header next to the "Search history" link. Confirm that you want to clear your search history. The page should refresh. Navigate to your account -> Your search history to confirm that your search history has been cleared. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 89579 [details] [review] Bug 22881: Trying to clear search history via the navbar X doesn't clear any searches This patch undoes a mistake introduced in my patch for Bug 21479. A "preventDefault()" was added to the search history clear button by mistake. The "confirmDelete" function only works if the default action of the link is allowed to complete. To test you must have the EnableOpacSearchHistory system preference enabled. Apply the patch and log into the OPAC as a patron who has a search history. Click the "X" link in the header next to the "Search history" link. Confirm that you want to clear your search history. The page should refresh. Navigate to your account -> Your search history to confirm that your search history has been cleared. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.06 backported to 18.05.x for 18.05.13 |