When you try to delete your search history using this item, it asks if you are really sure. However, even if you confirm, it does not delete your history and instead just sends you to the search history summary. We should correct this. If you want to check this issue: -Connect to your account. -Make some searches. -Try to clear your history using the "Clear Search History" item in the user menu. -Confirm the action -Check if your search history is empty or not.
Created attachment 182596 [details] [review] Bug 39680: "Clear" menu item doesn't delete search history This patch fixes the behavior of the OPAC's "Clear" link, which was not updated to work with CSRF protection. To test: - If necessary, go to Administration -> System preferences in the staff interface and set the EnableOpacSearchHistory preference to "Keep." - Log in to the OPAC. - If necessary, perform several catalog searches in order to populate your search history. - Expand the user menu in the upper right-hand corner and click the "Clear" link next to "Search history." - You should be prompted to confirm. - After confirming your search history should be empty. Sponsored-by: Athens County Public Libraries
Created attachment 182626 [details] [review] Bug 39680: "Clear" menu item doesn't delete search history This patch fixes the behavior of the OPAC's "Clear" link, which was not updated to work with CSRF protection. To test: - If necessary, go to Administration -> System preferences in the staff interface and set the EnableOpacSearchHistory preference to "Keep." - Log in to the OPAC. - If necessary, perform several catalog searches in order to populate your search history. - Expand the user menu in the upper right-hand corner and click the "Clear" link next to "Search history." - You should be prompted to confirm. - After confirming your search history should be empty. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 182719 [details] [review] Bug 39680: "Clear" menu item doesn't delete search history This patch fixes the behavior of the OPAC's "Clear" link, which was not updated to work with CSRF protection. To test: - If necessary, go to Administration -> System preferences in the staff interface and set the EnableOpacSearchHistory preference to "Keep." - Log in to the OPAC. - If necessary, perform several catalog searches in order to populate your search history. - Expand the user menu in the upper right-hand corner and click the "Clear" link next to "Search history." - You should be prompted to confirm. - After confirming your search history should be empty. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed for 25.05! Well done everyone, thank you!