| Summary: | ILS-DI: RenewLoan explodes in error | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Web services | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, martin.renvoize, nick |
| Version: | Main | Keywords: | regression |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 21206 | ||
| Bug Blocks: | 22742 | ||
| Attachments: |
Bug 22891: Add tests
Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI) Bug 22891: Add tests Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI) |
||
|
Description
Katrin Fischer
2019-05-11 09:56:44 UTC
Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem Created attachment 89640 [details] [review] Bug 22891: Add tests Created attachment 89641 [details] [review] Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI) From commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem A missing 'unless' test made RenewHold return prematurely: return $issue; should have been return unless $issue; Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 With different situations: 1. Item is checked out to the patron 2. Item is not checked out to the patron 3. Item does not exist 4. Patron does not exist Created attachment 89650 [details] [review] Bug 22891: Add tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 89651 [details] [review] Bug 22891: (bug 21206 follow-up) Fix RenewHold (ILS-DI) From commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem A missing 'unless' test made RenewHold return prematurely: return $issue; should have been return unless $issue; Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 With different situations: 1. Item is checked out to the patron 2. Item is not checked out to the patron 3. Item does not exist 4. Patron does not exist Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Combining SO and QA Awesome work all! Pushed to master for 19.05 Bug caused by enhancement not in 18.11.x series. |