| Summary: | Circulation Overdues report patron link goes to patron's holds tab | ||
|---|---|---|---|
| Product: | Koha | Reporter: | John Yorio <jyorio> |
| Component: | Circulation | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arm, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, lucas, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.02
|
|
| Circulation function: | |||
| Bug Depends on: | 18403 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 23097: Fix regression on overdues report and link patrons to moremember
Bug 23097: Fix regression on overdues report and link patrons to moremember Bug 23097: Fix regression on overdues report and link patrons to moremember |
||
|
Description
John Yorio
2019-06-11 16:40:37 UTC
Created attachment 90705 [details] [review] Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front Created attachment 90768 [details] [review] Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Hum yes, not sure what happened to this occurrence, it has been handled in a separate commit which was not related. Looks like a wrong rebase conflict resolution. Created attachment 90885 [details] [review] Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.02 backported to 18.11.x for 18.11.08 |