Steps to reproduce: Go to Circulation Click Overdues Apply any filters you know will return overdue items Click Apply Filter Click on a patron Notice that it takes you to their Holds tab, and the URL ends with #reserves At least as recently as 17.11, clicking the link took you to the patron's detail screen, not their holds.
Created attachment 90705 [details] [review] Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front
Created attachment 90768 [details] [review] Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Hum yes, not sure what happened to this occurrence, it has been handled in a separate commit which was not related. Looks like a wrong rebase conflict resolution.
Created attachment 90885 [details] [review] Bug 23097: Fix regression on overdues report and link patrons to moremember The link from the patron name in the circulation > overdues report shouldn't point to the reserves tab, as this report is about checkouts. The patch restores the behaviour as it was in 17.11. To test: - Make sure you have a patron account with overdue items - If you don't have one, check out an item with specified due date in the past - Go to Circulation > Overdues - Veriy the overdue shows - Click on the patron name that is linked - Verify you go to the checkouts tab in patron account with holds tab selected - Apply patch - Reload Overdues report - Verify the link now leads to the Details tab with the checkouts tab in front Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.02
backported to 18.11.x for 18.11.08