Bug 23124

Summary: Fields in DefaultPatronSearchFields are not validated and can break patron searching
Product: Koha Reporter: Nick Clemens <nick>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: dcook, gmcharlt, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 22844    
Bug Blocks:    

Description Nick Clemens 2019-06-14 13:16:44 UTC
We should probably just trim this string on save?


To recreate:
1 - Add a trailing space to DefaultPatronSearchFields
2 - Attempt to search for patrons
3 - Error!
Comment 1 Jonathan Druart 2019-06-20 00:18:05 UTC
I think we should fix it on top of bug 22844.
Comment 2 David Cook 2023-11-14 22:19:44 UTC
I'm going to rename this one as it's part of a larger problem where fields in DefaultPatronSearchFields aren't validated and so a mistake in this syspref will break patron search.
Comment 3 David Cook 2023-11-14 22:20:01 UTC
(In reply to Jonathan Druart from comment #1)
> I think we should fix it on top of bug 22844.

That would be a good alternative of course
Comment 4 Nick Clemens 2023-11-16 11:59:09 UTC
This field is now controlled by a selection editor - so doesn't accept manual input - can we consider this fixed?
Comment 5 David Cook 2023-11-16 23:50:17 UTC
(In reply to Nick Clemens from comment #4)
> This field is now controlled by a selection editor - so doesn't accept
> manual input - can we consider this fixed?

Yeah that works for me