Bug 23124 - Fields in DefaultPatronSearchFields are not validated and can break patron searching
Summary: Fields in DefaultPatronSearchFields are not validated and can break patron se...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 22844
Blocks:
  Show dependency treegraph
 
Reported: 2019-06-14 13:16 UTC by Nick Clemens (kidclamp)
Modified: 2024-07-04 20:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2019-06-14 13:16:44 UTC
We should probably just trim this string on save?


To recreate:
1 - Add a trailing space to DefaultPatronSearchFields
2 - Attempt to search for patrons
3 - Error!
Comment 1 Jonathan Druart 2019-06-20 00:18:05 UTC
I think we should fix it on top of bug 22844.
Comment 2 David Cook 2023-11-14 22:19:44 UTC
I'm going to rename this one as it's part of a larger problem where fields in DefaultPatronSearchFields aren't validated and so a mistake in this syspref will break patron search.
Comment 3 David Cook 2023-11-14 22:20:01 UTC
(In reply to Jonathan Druart from comment #1)
> I think we should fix it on top of bug 22844.

That would be a good alternative of course
Comment 4 Nick Clemens (kidclamp) 2023-11-16 11:59:09 UTC
This field is now controlled by a selection editor - so doesn't accept manual input - can we consider this fixed?
Comment 5 David Cook 2023-11-16 23:50:17 UTC
(In reply to Nick Clemens from comment #4)
> This field is now controlled by a selection editor - so doesn't accept
> manual input - can we consider this fixed?

Yeah that works for me