Description
Owen Leonard
2019-06-18 12:03:59 UTC
The specific issue I see is that the first time a transfer is triggered "#item-transfer-modal" is triggered and when you clear it, the check-in table reloads as expected. If an item that is already in transit is checked in, the modal that's triggered is "#wrong-transfer-modal" and when you clear this modal, the check-in table is completely cleared. So it's the second case that creates the problem for our staff. George (In reply to George Williams (NEKLS) from comment #1) > If an item that is already in transit is checked > in, the modal that's triggered is "#wrong-transfer-modal" and when you clear > this modal, the check-in table is completely cleared. Yes, that's right. Thank you for clarifying. Created attachment 91559 [details] [review] Bug 23145: Confirming transfer during checkin clears the table of previously checked-in items This patch corrects the checkin template so that checking in an item with an existing transfer does not clear the page of previous checkouts. To test, apply the patch and check in some items. - After each checkin the returned item should appear in the table of checkouts. - Check in an item which belongs to another branch. You will be asked to confirm that the items requires a transfer. When the page reloads you should see the same previous checkins in the table. - Check in that same item again. You will be again asked to confirm. Before this page, confirming the transfer would reload the page and clear the list of checkins. Now the page should reload and the table of checkins should still show the previously checked-in items. Created attachment 91574 [details] [review] Bug 23145: Confirming transfer during checkin clears the table of previously checked-in items This patch corrects the checkin template so that checking in an item with an existing transfer does not clear the page of previous checkouts. To test, apply the patch and check in some items. - After each checkin the returned item should appear in the table of checkouts. - Check in an item which belongs to another branch. You will be asked to confirm that the items requires a transfer. When the page reloads you should see the same previous checkins in the table. - Check in that same item again. You will be again asked to confirm. Before this page, confirming the transfer would reload the page and clear the list of checkins. Now the page should reload and the table of checkins should still show the previously checked-in items. Test all the actions when checking in an item which is already in transit: OK, Print transfer slip, and Cancel transfer. Created attachment 91610 [details] [review] Bug 23145: Confirming transfer during checkin clears the table of previously checked-in items This patch corrects the checkin template so that checking in an item with an existing transfer does not clear the page of previous checkouts. To test, apply the patch and check in some items. - After each checkin the returned item should appear in the table of checkouts. - Check in an item which belongs to another branch. You will be asked to confirm that the items requires a transfer. When the page reloads you should see the same previous checkins in the table. - Check in that same item again. You will be again asked to confirm. Before this page, confirming the transfer would reload the page and clear the list of checkins. Now the page should reload and the table of checkins should still show the previously checked-in items. Test all the actions when checking in an item which is already in transit: OK, Print transfer slip, and Cancel transfer. Signed-off-by: George Williams <george@nekls.org> QA: Looking here Created attachment 91622 [details] [review] Bug 23145: Confirming transfer during checkin clears the table of previously checked-in items This patch corrects the checkin template so that checking in an item with an existing transfer does not clear the page of previous checkouts. To test, apply the patch and check in some items. - After each checkin the returned item should appear in the table of checkouts. - Check in an item which belongs to another branch. You will be asked to confirm that the items requires a transfer. When the page reloads you should see the same previous checkins in the table. - Check in that same item again. You will be again asked to confirm. Before this page, confirming the transfer would reload the page and clear the list of checkins. Now the page should reload and the table of checkins should still show the previously checked-in items. Test all the actions when checking in an item which is already in transit: OK, Print transfer slip, and Cancel transfer. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |