When checking in an item which has a hold, the confirmation modal has an option, "Ignore," which takes no action but dismisses the modal. The same functionality should be applied to other modals which require no further action: Confirmation of a new transfer and confirmation of a transfer already in progress.
Created attachment 91583 [details] [review] Bug 23328: Some check-in messages should be dismissable There are several cases where the check-in process displays a modal asking for confirmation. There are several cases where confirming or dismissing the modal unnecessarily reloads the page. In cases where no server-side action is necessary, the modal should be dismissed without submitting a form. To test, apply the patch and go to Circulation -> Check in With AutomaticItemReturn enabled and AllowReturnToBranch set to "any library," - Check in an item which belongs at another library and is not already in-transit. In the confirmation modal which appears, clicking the "OK" button should close the modal without reloading the page. - Check in another item from anther branch. In the confirmation modal clicking the "Print slip" button should trigger a pop-up window for printing a slip but the modal should be dismissed without reloading the page. - Check in an item which is already in-transit to another branch. In the confirmation modal, clicking either the "OK" or "Print transfer slip" buttons should dismiss the modal without reloading the page. - Clicking the "Cancel transfer" button should work as before: The page reloads and the transfer is canceled. With AutomaticItemReturn disabled, - Check in an item belonging to another library. The confirmation modal should ask you whether you want to "Transfer now?" Clicking "No" should dismiss the modal without reloading the page. The other options should reload the page and initiate the transfer. With AllowReturnToBranch set to "only the library the item is from," - Check in an item belonging to another library. You should see a "Cannot check in" modal. Clicking the "OK" button should close the modal without reloading the page.
Created attachment 91671 [details] [review] Bug 23328: Some check-in messages should be dismissable There are several cases where the check-in process displays a modal asking for confirmation. There are several cases where confirming or dismissing the modal unnecessarily reloads the page. In cases where no server-side action is necessary, the modal should be dismissed without submitting a form. To test, apply the patch and go to Circulation -> Check in With AutomaticItemReturn enabled and AllowReturnToBranch set to "any library," - Check in an item which belongs at another library and is not already in-transit. In the confirmation modal which appears, clicking the "OK" button should close the modal without reloading the page. - Check in another item from anther branch. In the confirmation modal clicking the "Print slip" button should trigger a pop-up window for printing a slip but the modal should be dismissed without reloading the page. - Check in an item which is already in-transit to another branch. In the confirmation modal, clicking either the "OK" or "Print transfer slip" buttons should dismiss the modal without reloading the page. - Clicking the "Cancel transfer" button should work as before: The page reloads and the transfer is canceled. With AutomaticItemReturn disabled, - Check in an item belonging to another library. The confirmation modal should ask you whether you want to "Transfer now?" Clicking "No" should dismiss the modal without reloading the page. The other options should reload the page and initiate the transfer. With AllowReturnToBranch set to "only the library the item is from," - Check in an item belonging to another library. You should see a "Cannot check in" modal. Clicking the "OK" button should close the modal without reloading the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 91869 [details] [review] Bug 23328: Some check-in messages should be dismissable There are several cases where the check-in process displays a modal asking for confirmation. There are several cases where confirming or dismissing the modal unnecessarily reloads the page. In cases where no server-side action is necessary, the modal should be dismissed without submitting a form. To test, apply the patch and go to Circulation -> Check in With AutomaticItemReturn enabled and AllowReturnToBranch set to "any library," - Check in an item which belongs at another library and is not already in-transit. In the confirmation modal which appears, clicking the "OK" button should close the modal without reloading the page. - Check in another item from anther branch. In the confirmation modal clicking the "Print slip" button should trigger a pop-up window for printing a slip but the modal should be dismissed without reloading the page. - Check in an item which is already in-transit to another branch. In the confirmation modal, clicking either the "OK" or "Print transfer slip" buttons should dismiss the modal without reloading the page. - Clicking the "Cancel transfer" button should work as before: The page reloads and the transfer is canceled. With AutomaticItemReturn disabled, - Check in an item belonging to another library. The confirmation modal should ask you whether you want to "Transfer now?" Clicking "No" should dismiss the modal without reloading the page. The other options should reload the page and initiate the transfer. With AllowReturnToBranch set to "only the library the item is from," - Check in an item belonging to another library. You should see a "Cannot check in" modal. Clicking the "OK" button should close the modal without reloading the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00