| Summary: | Database Updates broken due to conflicts in bug 21073 and bug 22053 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Installation and upgrade (command-line installer) | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | agustinmoyano, alex.arnaud, axel.amghar, dcook, fridolin.somers, gmcharlt, jonathan.druart, jose-mario.monteiro-santos, martin.renvoize, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 21073, 22053, 23171 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 23168: Enable plugins using plain SQL
Bug 23168: Enable plugins using plain SQL Bug 23168: Enable plugins using plain SQL Bug 23168: Enable plugins using plain SQL Bug 23168: Enable plugins using plain SQL |
||
|
Description
Martin Renvoize (ashimema)
2019-06-20 09:44:18 UTC
Thankfully.. this one does only effect master at the moment. We may ask to run an atomic perl script after upgrade ? I think if anyway possible we should avoid separate update scripts. They get missed too often and cause lots of issues then. I have a patch for this Created attachment 90851 [details] [review] Bug 23168: Enable plugins using plain SQL Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 90852 [details] [review] Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 90853 [details] [review] Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 90854 [details] [review] Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 90855 [details] [review] Bug 23168: Enable plugins using plain SQL To test: - On a clean 18.11.x, install a plugin [1] - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: Notice there's a __INSTALLED_VERSION__ line for your plugin - Checkout latest master, restart all the things - Run: $ updatedatabase => FAIL: It fails on 18.12.00.069 because the plugin_methods table doesn't exist - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => FAIL: No __ENABLED__ line for your plugin - Apply the patch - Run: $ updatedatabase => SUCCESS: Update passes the 18.12.00.069 step correctly - Run: $ sudo koha-mysql kohadev > SELECT * FROM plugin_data; => SUCCESS: There's an __ENABLED__ line for your plugin - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Test plan works for me, Passing QA.. thanks for the quick fix Tomas. Nice work! Pushed to master for 19.11.00 Isn't it the same problem at 19.06.00.006? |