Bug 23171 - The plugin_methods table should not include imported methods
Summary: The plugin_methods table should not include imported methods
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Plugin architecture (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 22832 21073
Blocks: 23168
  Show dependency tree / graph
 
Reported: 2019-06-20 11:51 UTC by Martin Renvoize (ashimema)
Modified: 2022-11-11 10:34 UTC (History)
16 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 23171: Only record actual plugin methods (1.29 KB, patch)
2019-06-20 12:43 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2019-06-20 11:51:12 UTC 
Bug #21073 introduced the plugin_methods table, but the methods being added include all inherited and imported methods alongside those implemented by the plugin in question... we should limit to those implemented directly by the plugin.
Comment 1 Martin Renvoize (ashimema) 2019-06-20 12:43:41 UTC 
Created attachment 90848 [details] [review]
Bug 23171: Only record actual plugin methods
Comment 2 Martin Renvoize (ashimema) 2019-06-20 13:19:38 UTC 
Grr, this doesn't work as Class::Inspector doesn't differentiate between imported routines and local routines (only inherited ones are taken account of).

See https://github.com/plicease/Class-Inspector/issues/1 for further details.