Bug 23171

Summary: The plugin_methods table should not include imported methods
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Plugin architectureAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: CLOSED WONTFIX QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: agustinmoyano, arthur.suzuki, black23, dcook, fridolin.somers, jonathan.druart, kyle, magnus, martin.renvoize, mirko, mtj, mtompset, nick, rbit, tomascohen, wizzyrea
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 22832, 21073    
Bug Blocks: 23168    
Attachments: Bug 23171: Only record actual plugin methods

Description Martin Renvoize (ashimema) 2019-06-20 11:51:12 UTC
Bug #21073 introduced the plugin_methods table, but the methods being added include all inherited and imported methods alongside those implemented by the plugin in question... we should limit to those implemented directly by the plugin.
Comment 1 Martin Renvoize (ashimema) 2019-06-20 12:43:41 UTC
Created attachment 90848 [details] [review]
Bug 23171: Only record actual plugin methods
Comment 2 Martin Renvoize (ashimema) 2019-06-20 13:19:38 UTC
Grr, this doesn't work as Class::Inspector doesn't differentiate between imported routines and local routines (only inherited ones are taken account of).

See https://github.com/plicease/Class-Inspector/issues/1 for further details.