| Summary: | SIP/Transaction.t is failing randomly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | 22433 | ||
| Bug Blocks: | 25551 | ||
| Attachments: |
Bug 23211: Prevent SIP/Transaction.t to fail randomly
Bug 23211: Prevent SIP/Transaction.t to fail randomly |
||
|
Description
Jonathan Druart
2019-06-25 22:42:00 UTC
The checkout failed because patron's category is the one used for statistics (category_type=X).
To recreate the failure:
modified: t/db_dependent/SIP/Transaction.t
@ Transaction.t:37 @ subtest fill_holds_at_checkout => sub {
plan tests => 6;
- my $category = $builder->build({ source => 'Category' });
+ my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }});
my $branch = $builder->build({ source => 'Branch' });
my $borrower = $builder->build({ source => 'Borrower', value =>{
branchcode => $branch->{branchcode},
Created attachment 91006 [details] [review] Bug 23211: Prevent SIP/Transaction.t to fail randomly The checkout failed because patron's category is the one used for statistics (category_type=X). To recreate the failure: modified: t/db_dependent/SIP/Transaction.t @ Transaction.t:37 @ subtest fill_holds_at_checkout => sub { plan tests => 6; - my $category = $builder->build({ source => 'Category' }); + my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }}); my $branch = $builder->build({ source => 'Branch' }); my $borrower = $builder->build({ source => 'Borrower', value =>{ branchcode => $branch->{branchcode}, Created attachment 91010 [details] [review] Bug 23211: Prevent SIP/Transaction.t to fail randomly The checkout failed because patron's category is the one used for statistics (category_type=X). To recreate the failure: modified: t/db_dependent/SIP/Transaction.t @ Transaction.t:37 @ subtest fill_holds_at_checkout => sub { plan tests => 6; - my $category = $builder->build({ source => 'Category' }); + my $category = $builder->build({ source => 'Category', value => { category_type => 'X' }}); my $branch = $builder->build({ source => 'Branch' }); my $borrower = $builder->build({ source => 'Borrower', value =>{ branchcode => $branch->{branchcode}, Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as described and causes no regressions.. Thanks Jonathan. Going straight for a PQA Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |