Bug 22433 - SIP/Transaction.t is failing randomly
Summary: SIP/Transaction.t is failing randomly
Status: Pushed to Stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Target Milestone: ---
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-28 13:58 UTC by Jonathan Druart
Modified: 2019-05-24 13:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:
19.05.00, 18.11.06


Attachments
Bug 22433: Add debug statement to Transaction.t (1.33 KB, patch)
2019-05-09 18:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 22433: Add debug statement to Transaction.t (1.53 KB, patch)
2019-05-10 13:14 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 22433: Use Data::Dumper instead of Data::Printer (1.27 KB, patch)
2019-05-10 17:32 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2019-02-28 13:58:09 UTC
On Master_D9:

koha_1       |     #   Failed test 'Bib has 1 holds remaining'
koha_1       |     #   at t/db_dependent/SIP/Transaction.t line 90.
koha_1       |     #          got: '2'
koha_1       |     #     expected: '1'
koha_1       |     # Looks like you failed 1 test of 5.
koha_1       | 
koha_1       | #   Failed test 'fill_holds_at_checkout'
koha_1       | #   at t/db_dependent/SIP/Transaction.t line 93.
koha_1       | # Looks like you failed 1 test of 4.
koha_1       | [21:17:57] t/db_dependent/SIP/Transaction.t
Comment 1 Jonathan Druart 2019-05-09 18:05:10 UTC
We got this failure a lot the last months.
Comment 2 Jonathan Druart 2019-05-09 18:06:31 UTC
Created attachment 89521 [details] [review]
Bug 22433: Add debug statement to Transaction.t

Hard to know what's going on here without more info. Adding this output
may help to investigate more.

Test plan:
Make sure the tests still pass

If it fails, please paste the output!!
Comment 3 Martin Renvoize 2019-05-10 13:14:58 UTC
Created attachment 89547 [details] [review]
Bug 22433: Add debug statement to Transaction.t

Hard to know what's going on here without more info. Adding this output
may help to investigate more.

Test plan:
Make sure the tests still pass

If it fails, please paste the output!!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2019-05-10 13:17:42 UTC
Signing off as it's just a debugging addition.
Comment 5 Martin Renvoize 2019-05-10 13:18:13 UTC
Let's go straight for PQA.. no harm in it and it'll be helpful in finding the actual root of the issue.
Comment 6 Nick Clemens 2019-05-10 17:12:29 UTC
Data::Printer isn't in our deps - can you use Data::Dumper instead?
Comment 7 Jonathan Druart 2019-05-10 17:32:54 UTC
Created attachment 89564 [details] [review]
Bug 22433: Use Data::Dumper instead of Data::Printer

Data::Printer is not in our deps
Comment 8 Jonathan Druart 2019-05-10 17:33:18 UTC
(In reply to Nick Clemens from comment #6)
> Data::Printer isn't in our deps - can you use Data::Dumper instead?

Yup, good catch! :)
Comment 9 Nick Clemens 2019-05-10 17:43:56 UTC
Awesome work all!

Pushed to master for 19.05
Comment 10 Martin Renvoize 2019-05-24 13:24:24 UTC
Pushed to 18.11.x for 18.11.06