Bug 23215

I think we might want to do some deprecation steps here first. 

Suggestion, for 20.11:
- Deprecate the plugin in the release notes
- Add information about deprecation to the Paypal system preferences
- Add an entry to the "system information" tab

For 21.05:
- Remove the code and enforce the switch

Where are we here? Should the deprecation be announced in 20.11?

I wonder if we aught to either grab the plugin as part of the upgrade if the syprefs are set.. or at the very least highlight to the user as upgrade time that they'll need to grab the plugin.. (and make sure we copy the config to somewhere so they can easily use it in the plugin config when they come to use that route)

Lets put a bold message about it being deprecated, in the release notes, and the about page!.

(In reply to Katrin Fischer from comment #1)
> I think we might want to do some deprecation steps here first. 
> 
> Suggestion, for 20.11:
> - Deprecate the plugin in the release notes
> - Add information about deprecation to the Paypal system preferences
> - Add an entry to the "system information" tab
> 
> For 21.05:
> - Remove the code and enforce the switch

^^ 100% agree with that

(In reply to Tomás Cohen Arazi from comment #5)
> (In reply to Katrin Fischer from comment #1)
> > I think we might want to do some deprecation steps here first. 
> > 
> > Suggestion, for 20.11:
> > - Deprecate the plugin in the release notes
> > - Add information about deprecation to the Paypal system preferences
> > - Add an entry to the "system information" tab
> > 
> > For 21.05:
> > - Remove the code and enforce the switch
> 
> ^^ 100% agree with that

Do you have time to do it? A few more strings are not bad right now, but should be added very soon.

Can we have a patch please?

Created attachment 120519 [details] [review]
Bug 23215: Remove PayPal-related sysprefs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Created attachment 120520 [details] [review]
Bug 23215: Remove traces of the PayPal feature

This patch removes the PayPal payments feature. It has been moved to
its' own plugin.

To test:
1. Apply this patches
2. Run:
   $ updatedatabase
=> SUCCESS: Database updates correctly
3. Run:
   $ koha-mysql kohadev
   > SELECT * FROM systempreferences WHERE variable LIKE 'paypal';
=> SUCCESS: No results
4. On the sysprefs, OPAC section
=> SUCCESS: No PayPal-related sysprefs show up
5. Add some charges to your patron
6. In the OPAC, log in and see your charges
=> SUCCESS: Nothing broken
7. Install the PayPal plugin [1] or any other payment plugin
8. Restart plack (mandatory for the PayPal plugin)
9. Set some random data in the config (or better, real sandbox testing
   data)
10. Go to the OPAC's account page and try to pay your debts (use the
    checkbox to select lines)
=> SUCCESS: The PayPal payment method shows, you can click the button,
    it fails due to bad config, but things work as expected.
11. Sign off :-D

[1] https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/releases

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Created attachment 120634 [details] [review]
Bug 23215: Remove PayPal-related sysprefs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Created attachment 120635 [details] [review]
Bug 23215: Remove PayPal-related sysprefs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Created attachment 120636 [details] [review]
Bug 23215: Remove traces of the PayPal feature

This patch removes the PayPal payments feature. It has been moved to
its' own plugin.

To test:
1. Apply this patches
2. Run:
   $ updatedatabase
=> SUCCESS: Database updates correctly
3. Run:
   $ koha-mysql kohadev
   > SELECT * FROM systempreferences WHERE variable LIKE 'paypal';
=> SUCCESS: No results
4. On the sysprefs, OPAC section
=> SUCCESS: No PayPal-related sysprefs show up
5. Add some charges to your patron
6. In the OPAC, log in and see your charges
=> SUCCESS: Nothing broken
7. Install the PayPal plugin [1] or any other payment plugin
8. Restart plack (mandatory for the PayPal plugin)
9. Set some random data in the config (or better, real sandbox testing
   data)
10. Go to the OPAC's account page and try to pay your debts (use the
    checkbox to select lines)
=> SUCCESS: The PayPal payment method shows, you can click the button,
    it fails due to bad config, but things work as expected.
11. Sign off :-D

[1] https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/releases

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Moving to Passed QA. RM can ask for another signer if need be. I tested thoroughly. Test end-to-end functionality with the PayPal plugin, which went perfectly. Also installed other plugins to ensure they continued to function, which they did.

Pushed to master for 21.05, thanks to everybody involved!

Enhancement not pushed to 20.11.x

Release notes needed for 21.05