Summary: | Remove type attribute from script tags: Reports | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, testopia |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 22956 | ||
Attachments: |
Bug 23227: Remove type attribute from script tags: Reports
Bug 23227: Remove type attribute from script tags: Reports Bug 23227: Remove type attribute from script tags: Reports Bug 23227: Remove type attribute from script tags: Reports Bug 23227: Remove type attribute from script tags: Reports |
Description
Owen Leonard
2019-06-27 13:35:50 UTC
Created attachment 91054 [details] [review] Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Created attachment 91299 [details] [review] Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 91352 [details] [review] Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Created attachment 91353 [details] [review] Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Created attachment 91387 [details] [review] Bug 23227: Remove type attribute from script tags: Reports This patch removes the "type" attribute from <script> tags in two reports templates. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Reports -> Dictionary - Delete - Specifying a date range for a date column - Reports -> Items lost - Report results -> Datatables functionality -> Selection tools for export Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |