Bug 23241

Summary:	Remove misc/bin/koha-index-daemon-ctl.sh
Product:	Koha	Reporter:	Martin Renvoize (ashimema) <martin.renvoize>
Component:	Command-line Utilities	Assignee:	Martin Renvoize (ashimema) <martin.renvoize>
Status:	Pushed to main ---	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, jonathan.druart, philip.orr, robin, tomascohen
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10665
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This script was never fully promoted or documented. It also required third party libraries to be installed. If you have been using this, please consider switching to the standard koha-indexer scripts.	Version(s) released in:	23.11.00
Circulation function:
Bug Depends on:	8519
Bug Blocks:
Attachments:	Bug 23241: Remove unused koha-index-daemon-ctl.sh Bug 23241: Remove unused koha-index-daemon-ctl.sh

Description Martin Renvoize (ashimema) 2019-07-01 09:45:18 UTC

We have had a daemon mode in rebuild_zebra.pl for a long time and have been using that as the default indexing daemon for years.. Should we deprecate the above script to prevent confusion for new users where indexing should just work out of the box without the need for installing external dependancies.

Comment 1 Katrin Fischer 2023-10-08 11:29:22 UTC

What's the status here? I get that the file does not related to the koha-indexer?

Comment 2 Martin Renvoize (ashimema) 2023-10-09 10:42:52 UTC

I believe it's still the case.. we only mention the script in the Makefile and don't actively use or encourage it anywhere.. I'm not sure it was ever documented either.

I vote to remove it still.

Comment 3 Martin Renvoize (ashimema) 2023-10-09 10:45:37 UTC

Created attachment 156730 [details] [review]
Bug 23241: Remove unused koha-index-daemon-ctl.sh

This script was never fully promoted or documented and it requires third
party libraries are installed to use. This patch removes it from the
repository and the Makefile so it is no longer installed.

Comment 4 Katrin Fischer 2023-10-09 19:23:01 UTC

Created attachment 156759 [details] [review]
Bug 23241: Remove unused koha-index-daemon-ctl.sh

This script was never fully promoted or documented and it requires third
party libraries are installed to use. This patch removes it from the
repository and the Makefile so it is no longer installed.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Katrin Fischer 2023-10-09 19:24:15 UTC

Moving to PQA.

Comment 6 Tomás Cohen Arazi (tcohen) 2023-10-10 12:23:00 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 7 Katrin Fischer 2023-10-10 13:51:28 UTC

I tried my hand at the release notes - please check!

Comment 8 Fridolin Somers 2023-10-12 20:48:02 UTC

I prefer not to push to 23.05.x