Bug 23283

Summary: cannot view/edit additional attributes in 18.11.x
Product: Koha Reporter: Lucas Gass <lucas>
Component: PatronsAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: critical    
Priority: P5 - low CC: fridolin.somers, gmcharlt, katrin.fischer, kyle.m.hall
Version: 18.11   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 22910    
Bug Blocks:    
Attachments: Bug 23283: cannot view/edit additional attributes in 18.11.x
Bug 23283: Counter patch modifying the template
Bug 23283: cannot view/edit additional attributes in 18.11.x
Bug 23283: cannot view/edit additional attributes in 18.11.x
Bug 23283: cannot view/edit additional attributes in 18.11.x

Description Lucas Gass 2019-07-08 21:00:56 UTC
TO TEST:

1. setup some additional patron attributes.
2. go to the patron details and add/edit "Additional attributes and identifiers"
3. see that no additional attributes show
Comment 1 Lucas Gass 2019-07-08 21:10:47 UTC
Created attachment 91419 [details] [review]
Bug 23283: cannot view/edit additional attributes in 18.11.x

TEST PLAN:
1. setup some additional patron attributes.
2. go to the patron details and add/edit "Additional attributes and identifiers"
3. see that no additional attributes show
4. apply patch
5. go to the patron details and add/edit "Additional attributes and identifiers"
6. additional attributes should show now
Comment 2 Mark Tompsett 2019-07-08 21:40:22 UTC
Created attachment 91420 [details] [review]
Bug 23283: Counter patch modifying the template
Comment 3 Lucas Gass 2019-07-10 02:46:34 UTC
Created attachment 91434 [details] [review]
Bug 23283: cannot view/edit additional attributes in 18.11.x

TEST PLAN:
1. setup some additional patron attributes.
2. go to the patron details and add/edit "Additional attributes and identifiers"
3. see that no additional attributes show
4. apply patch
5. go to the patron details and add/edit "Additional attributes and identifiers"
6. additional attributes should show now
Comment 4 Chris Cormack 2019-07-11 06:13:12 UTC
Created attachment 91454 [details] [review]
Bug 23283: cannot view/edit additional attributes in 18.11.x

TEST PLAN:
1. setup some additional patron attributes.
2. go to the patron details and add/edit "Additional attributes and
identifiers"
3. see that no additional attributes show
4. apply patch
5. go to the patron details and add/edit "Additional attributes and
identifiers"
6. additional attributes should show now

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Katrin Fischer 2019-07-11 15:02:11 UTC
Tested with the help of sandboxes this time :) Will add my SO line later, but if you push, feel free to add it.

Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 6 PTFS Europe Sandboxes 2019-07-11 15:08:34 UTC
Created attachment 91467 [details] [review]
Bug 23283: cannot view/edit additional attributes in 18.11.x

TEST PLAN:
1. setup some additional patron attributes.
2. go to the patron details and add/edit "Additional attributes and
identifiers"
3. see that no additional attributes show
4. apply patch
5. go to the patron details and add/edit "Additional attributes and
identifiers"
6. additional attributes should show now

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Martin <martin.renvoize@ptfs-europe.com>
Comment 7 Lucas Gass 2019-07-11 15:17:21 UTC
backported to 18.11.x for 18.11.08

Thanks everyone.
Comment 8 Katrin Fischer 2019-07-11 15:19:16 UTC
Ok, using the sandbox that I didn't create myself went wrong - suspect a bug there as I told it so use my data for sign-off - not it was Martin :)
Comment 9 Fridolin Somers 2019-07-22 16:02:40 UTC
In >= 19.05.x Bug 12159 made this change