Bug 22910 - Do not copy unique patron attributes to duplicated patron
Summary: Do not copy unique patron attributes to duplicated patron
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: paxed
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-15 10:58 UTC by paxed
Modified: 2019-05-15 12:27 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22910 - Do not copy unique patron attributes to duplicated patron (1.48 KB, patch)
2019-05-15 11:01 UTC, paxed
Details | Diff | Splinter Review
Bug 22910 - Do not copy unique patron attributes to duplicated patron (1.52 KB, patch)
2019-05-15 12:27 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2019-05-15 10:58:58 UTC
When creating a new patron by duplicating another, all of the patron attributes are also copied into the form. Some of those value may be unique, so don't copy those.
Comment 1 paxed 2019-05-15 11:01:57 UTC
Created attachment 89782 [details] [review]
Bug 22910 - Do not copy unique patron attributes to duplicated patron

When creating a new patron by duplicating another, all of the patron
attributes are also copied into the form. Some of those value may be
unique, so don't copy those.
    
1) Create patron attribute types, one with "unique identifier", one without.
2) Create or a patron so it has values in both of those attributes.
3) Duplicate the patron
4) The edit form should retain the values from the "original" patron.
5) Apply patch.
6) Duplicate the patron - this time the attributes with unique values
   are cleared.
Comment 2 Owen Leonard 2019-05-15 12:27:41 UTC
Created attachment 89783 [details] [review]
Bug 22910 - Do not copy unique patron attributes to duplicated patron

When creating a new patron by duplicating another, all of the patron
attributes are also copied into the form. Some of those value may be
unique, so don't copy those.

1) Create patron attribute types, one with "unique identifier", one without.
2) Create or a patron so it has values in both of those attributes.
3) Duplicate the patron
4) The edit form should retain the values from the "original" patron.
5) Apply patch.
6) Duplicate the patron - this time the attributes with unique values
   are cleared.

Signed-off-by: Pasi Kallinen <pasi.kallinen@koha-suomi.fi>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>