Summary: | Add columns configuration to cataloguing/z3950_search.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, george, martin.renvoize, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
Bug Depends on: | 23304 | ||
Bug Blocks: | 23441 | ||
Attachments: |
Bug 23307: Add columns configuration to cataloguing/z3950_search.tt
Bug 23307: Add columns configuration to cataloguing/z3950_search.tt Bug 23307: Add columns configuration to cataloguing/z3950_search.tt Bug 23307: Add columns configuration to cataloguing/z3950_search.tt |
Description
Owen Leonard
2019-07-12 14:16:38 UTC
Created attachment 91492 [details] [review] Bug 23307: Add columns configuration to cataloguing/z3950_search.tt This patch adds columns configuration to the DataTable which displays Z39.50 search results in the cataloging module. The Z39.50 results screen has its own server-side paging system, so I added some code to copy the page number information ("Page 2 / 6") to the DataTable toolbar for a more consistent appearance. The wording of that information has also been modified for consistency's sake. To test, apply the patch and restart Plack (or restart_all on kohadevbox) - Go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return multiple pages of results. - Confirm that the DataTable controls work correctly: Search, columns show/hide, export. - Confirm that the page number information is correct as you navigate through pages of results. - Go to Administration -> Columns settings. - Confirm that the columns configuration settings for the z3950_search table in the "Cataloging" section works correctly. Changes made here should be reflected in the table of Z39.50 search results. Created attachment 91535 [details] [review] Bug 23307: Add columns configuration to cataloguing/z3950_search.tt This patch adds columns configuration to the DataTable which displays Z39.50 search results in the cataloging module. The Z39.50 results screen has its own server-side paging system, so I added some code to copy the page number information ("Page 2 / 6") to the DataTable toolbar for a more consistent appearance. The wording of that information has also been modified for consistency's sake. To test, apply the patch and restart Plack (or restart_all on kohadevbox) - Go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return multiple pages of results. - Confirm that the DataTable controls work correctly: Search, columns show/hide, export. - Confirm that the page number information is correct as you navigate through pages of results. - Go to Administration -> Columns settings. - Confirm that the columns configuration settings for the z3950_search table in the "Cataloging" section works correctly. Changes made here should be reflected in the table of Z39.50 search results. - Test other tables which use columns configuration to confirm that the changes made in this patch doesn't disrupt their behavior. Test that any custom columns configuration are applied. For example: - Administration -> Libraries - Reports -> Saved reports - Circulation -> Holds queue Created attachment 91879 [details] [review] Bug 23307: Add columns configuration to cataloguing/z3950_search.tt This patch adds columns configuration to the DataTable which displays Z39.50 search results in the cataloging module. The Z39.50 results screen has its own server-side paging system, so I added some code to copy the page number information ("Page 2 / 6") to the DataTable toolbar for a more consistent appearance. The wording of that information has also been modified for consistency's sake. To test, apply the patch and restart Plack (or restart_all on kohadevbox) - Go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return multiple pages of results. - Confirm that the DataTable controls work correctly: Search, columns show/hide, export. - Confirm that the page number information is correct as you navigate through pages of results. - Go to Administration -> Columns settings. - Confirm that the columns configuration settings for the z3950_search table in the "Cataloging" section works correctly. Changes made here should be reflected in the table of Z39.50 search results. - Test other tables which use columns configuration to confirm that the changes made in this patch doesn't disrupt their behavior. Test that any custom columns configuration are applied. For example: - Administration -> Libraries - Reports -> Saved reports - Circulation -> Holds queue Signed-off-by: George Williams <george@nekls.org> I was able to follow the test plan without encountering any errors. I'd add, though, that it would be nice if the "Actions" column could be dropped from the export (it's about 200 characters wide and there's no way to turn it off and it adds no value to the export) and if the "Additional fields" column could be included in options with the "Column settings" button if AdditionalFieldsInZ3950ResultSearch is configured. Created attachment 92080 [details] [review] Bug 23307: Add columns configuration to cataloguing/z3950_search.tt This patch adds columns configuration to the DataTable which displays Z39.50 search results in the cataloging module. The Z39.50 results screen has its own server-side paging system, so I added some code to copy the page number information ("Page 2 / 6") to the DataTable toolbar for a more consistent appearance. The wording of that information has also been modified for consistency's sake. To test, apply the patch and restart Plack (or restart_all on kohadevbox) - Go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return multiple pages of results. - Confirm that the DataTable controls work correctly: Search, columns show/hide, export. - Confirm that the page number information is correct as you navigate through pages of results. - Go to Administration -> Columns settings. - Confirm that the columns configuration settings for the z3950_search table in the "Cataloging" section works correctly. Changes made here should be reflected in the table of Z39.50 search results. - Test other tables which use columns configuration to confirm that the changes made in this patch doesn't disrupt their behavior. Test that any custom columns configuration are applied. For example: - Administration -> Libraries - Reports -> Saved reports - Circulation -> Holds queue Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 (In reply to George Williams (NEKLS) from comment #4) > I was able to follow the test plan without encountering any errors. > > I'd add, though, that it would be nice if the "Actions" column could be > dropped from the export (it's about 200 characters wide and there's no way > to turn it off and it adds no value to the export) and if the "Additional > fields" column could be included in options with the "Column settings" > button if AdditionalFieldsInZ3950ResultSearch is configured. This looks like a distinct bug to me.. lets get that recorded. Enhancement not pushed to 19.05.x |